New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProxyException should also retain any suppressed exceptions from the original #136

Merged
merged 1 commit into from Nov 30, 2016

Conversation

Projects
None yet
3 participants
@jglick
Member

jglick commented Nov 29, 2016

Potentially relevant for Pipeline, especially after jenkinsci/workflow-api-plugin#18.

@reviewbybees

@reviewbybees

This comment has been minimized.

Show comment
Hide comment
@reviewbybees

reviewbybees Nov 29, 2016

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

reviewbybees commented Nov 29, 2016

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@oleg-nenashev

This comment has been minimized.

Show comment
Hide comment
@oleg-nenashev
Member

oleg-nenashev commented Nov 29, 2016

🐝

@jglick

This comment has been minimized.

Show comment
Hide comment
@jglick

jglick Nov 30, 2016

Member

Hmm, the ci.jenkins.io build seems badly broken.

Anyway, @reviewbybees done

Member

jglick commented Nov 30, 2016

Hmm, the ci.jenkins.io build seems badly broken.

Anyway, @reviewbybees done

@oleg-nenashev oleg-nenashev merged commit b3d7136 into jenkinsci:master Nov 30, 2016

1 of 2 checks passed

continuous-integration/jenkins/pr-head This commit cannot be built
Details
Jenkins This pull request looks good
Details
@oleg-nenashev

This comment has been minimized.

Show comment
Hide comment
@oleg-nenashev

oleg-nenashev Nov 30, 2016

Member

@jglick Any need to backport it to 2.x?

Member

oleg-nenashev commented Nov 30, 2016

@jglick Any need to backport it to 2.x?

@jglick jglick deleted the jglick:ProxyException-suppressed branch Nov 30, 2016

@jglick

This comment has been minimized.

Show comment
Hide comment
@jglick

jglick Nov 30, 2016

Member

Any need to backport it to 2.x?

No, it is just something I happened to notice and decided to fix—I am not waiting on it.

Member

jglick commented Nov 30, 2016

Any need to backport it to 2.x?

No, it is just something I happened to notice and decided to fix—I am not waiting on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment