Improve diagnostics for JarCache write errors (related to JENKINS-36947) #91

Merged
merged 5 commits into from Aug 5, 2016

Conversation

Projects
None yet
2 participants
@oleg-nenashev

This comment has been minimized.

Show comment
Hide comment
Member

oleg-nenashev commented Jul 26, 2016

👍

+ Files.createDirectories(file.toPath());
+ return;
+ } catch (ClassNotFoundException e) {
+ // JDK6

This comment has been minimized.

@oleg-nenashev

oleg-nenashev Aug 3, 2016

Member

I think we can finally drop support of Java 6 in remoting.
@stephenc is going to introduce some incompatible code, and maybe we will need remoting 3 in any case

@oleg-nenashev

oleg-nenashev Aug 3, 2016

Member

I think we can finally drop support of Java 6 in remoting.
@stephenc is going to introduce some incompatible code, and maybe we will need remoting 3 in any case

This comment has been minimized.

@olivergondza

olivergondza Aug 3, 2016

Member

Is there any chance to cut a JDK6 release with this fix, first?

@olivergondza

olivergondza Aug 3, 2016

Member

Is there any chance to cut a JDK6 release with this fix, first?

This comment has been minimized.

@oleg-nenashev

oleg-nenashev Aug 3, 2016

Member

Sure. I've forgotten you're on 1.580.
Right now there is no strong need to migrate, so I would not like to hurry too much

@oleg-nenashev

oleg-nenashev Aug 3, 2016

Member

Sure. I've forgotten you're on 1.580.
Right now there is no strong need to migrate, so I would not like to hurry too much

This comment has been minimized.

@olivergondza

olivergondza Aug 4, 2016

Member

Not any more, it is 1.609 but the limitation remains.

@olivergondza

olivergondza Aug 4, 2016

Member

Not any more, it is 1.609 but the limitation remains.

+ // Fallback
+ if (!file.mkdirs()) {
+ if (!file.isDirectory()) {
+ throw new IOException("Directory not created");

This comment has been minimized.

@oleg-nenashev

oleg-nenashev Aug 3, 2016

Member

Maybe not ideal. E.g. we do not check this directory is writable, etc.
But it's definitely better than the original code

@oleg-nenashev

oleg-nenashev Aug 3, 2016

Member

Maybe not ideal. E.g. we do not check this directory is writable, etc.
But it's definitely better than the original code

This comment has been minimized.

@olivergondza

olivergondza Aug 3, 2016

Member

Which directory, the target one? I think that is out of the scope of the method.

@olivergondza

olivergondza Aug 3, 2016

Member

Which directory, the target one? I think that is out of the scope of the method.

This comment has been minimized.

@oleg-nenashev

oleg-nenashev Aug 5, 2016

Member

Maybe

@oleg-nenashev

This comment has been minimized.

Show comment
Hide comment
@oleg-nenashev

oleg-nenashev Aug 3, 2016

Member

re-👍

Member

oleg-nenashev commented Aug 3, 2016

re-👍

@oleg-nenashev oleg-nenashev changed the title from Improve diagnostics for JENKINS-36947 to Improve diagnostics for JarCache write errors (related to JENKINS-36947) Aug 5, 2016

@oleg-nenashev oleg-nenashev merged commit 62aad35 into jenkinsci:master Aug 5, 2016

1 check passed

Jenkins This pull request looks good
Details

oleg-nenashev added a commit that referenced this pull request Aug 5, 2016

oleg-nenashev added a commit to oleg-nenashev/jenkins that referenced this pull request Aug 6, 2016

[JENKINS-37140,JENKINS-36991] - Upgrade remoting to 2.61
Fixed issues:
* [JENKINS-37140](https://issues.jenkins-ci.org/browse/JENKINS-37140) -
JNLP Slave connection issue with *JNLP3-connect* protocol when the generated encrypted cookie contains a newline symbols.
(jenkinsci/remoting#95)
* [JENKINS-36991](https://issues.jenkins-ci.org/browse/JENKINS-36991) -
Unable to load class when remote classloader gets interrupted.
(jenkinsci/remoting#94)

Enhancements:
* Improve diagnostics for Jar Cache write errors.
(jenkinsci/remoting#91)

oleg-nenashev added a commit to jenkinsci/jenkins that referenced this pull request Aug 6, 2016

[JENKINS-37140,JENKINS-36991] - Upgrade remoting to 2.61 (#2497)
Fixed issues:
* [JENKINS-37140](https://issues.jenkins-ci.org/browse/JENKINS-37140) -
JNLP Slave connection issue with *JNLP3-connect* protocol when the generated encrypted cookie contains a newline symbols.
(jenkinsci/remoting#95)
* [JENKINS-36991](https://issues.jenkins-ci.org/browse/JENKINS-36991) -
Unable to load class when remote classloader gets interrupted.
(jenkinsci/remoting#94)

Enhancements:
* Improve diagnostics for Jar Cache write errors.
(jenkinsci/remoting#91)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment