Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-30554] Allow Artifact Deploy step #15

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@Brantone
Copy link
Contributor

Brantone commented Sep 22, 2015

(2nd attempt at this ...)
Cleaned up white-spaces, was a bit inconsistent.
As for actually allowing the "Artifact Deploy" notifier:
It was unclear why the step was disabled, so to provide better management control, added a checkbox option to global config to specify if repo is "deployable". If no repos are found, then disables the notifier step (worth adding info/mention to plugin page).
Also: fixes bug where the repo wouldn't be listed on job config page until page has been saved and re-config shows list.

Brantone added some commits Sep 21, 2015

[JENKINS-30554] Fix up functionality for allowing ArtifactDeploy, inc…
…luding: proper retrieval for job config list and added new option to repo config and gather list based on if deploy is allowed
@Brantone

This comment has been minimized.

Copy link
Contributor Author

Brantone commented Mar 17, 2016

Chance of merging?

@Brantone

This comment has been minimized.

Copy link
Contributor Author

Brantone commented Sep 23, 2016

Merge? Would be quite useful.
Otherwise would be worth recommending using https://wiki.jenkins-ci.org/display/JENKINS/Nexus+Artifact+Uploader instead.

@jgangemi

This comment has been minimized.

Copy link
Contributor

jgangemi commented Jan 23, 2018

howdy - are you still interested in seeing this merged? if yes, can you please rebase your request? thanks!

@Brantone

This comment has been minimized.

Copy link
Contributor Author

Brantone commented Jan 23, 2018

Yup, will take a look

@jgangemi

This comment has been minimized.

Copy link
Contributor

jgangemi commented Jan 23, 2018

i just merged in #21, so hopefully you didn't start on this yet. if you did, sorry.

@jgangemi

This comment has been minimized.

Copy link
Contributor

jgangemi commented Jan 23, 2018

ahh - so now that i've fully wrapped my head around this, is this even still necessary given the other plugin exists? i'm happy to support it (i actually started on a plugin to do something w/ local artifact version resolution that should probably be better off merged here) but i'm curious to know why it was disabled in the first place.

i was unable to find anything in the commit history, @imod can you offer any insight here?

@imod

This comment has been minimized.

Copy link
Member

imod commented Jan 24, 2018

@jgangemi as far as I can remember, it was just not properly tested yet

@Brantone

This comment has been minimized.

Copy link
Contributor Author

Brantone commented Jul 16, 2018

I was starting to re-visit this a while back, but sadly got pulled into other projects so haven't had a chance to touch this. I may be doing some more in the future, but that remains up in the air.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.