Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jenkins 2.3+ compatibility : fixed parameter name #19

Merged
merged 1 commit into from May 24, 2017

Conversation

@fabdouglas
Copy link
Contributor

fabdouglas commented May 19, 2016

Since Jenkins 2.3, there is a protection that prevents repository-connector-plugin to create a variable while the job is being started.
https://wiki.jenkins-ci.org/display/SECURITY/Jenkins+Security+Advisory+2016-05-11 and more precisely : SECURITY-170 / CVE-2016-3721

This PR makes compatible this plugin to Jenkins 2.3 and displays correctly the property name (when defined) instead of "group.artifact"

Since Jenkins 2.3, there is a protection that prevents repository-connector-plugin to create a variable while the job is being started.
https://wiki.jenkins-ci.org/display/SECURITY/Jenkins+Security+Advisory+2016-05-11 and more precisely : SECURITY-170 / CVE-2016-3721

This PR makes compatible this plugin to Jenkins 2.3 and displays correctly the property name (when defined) instead of "group.artifact"
@sreich

This comment has been minimized.

Copy link

sreich commented Jun 22, 2016

i'm also affected by this.

this doesn't fix version artifact, does it?

specifically my issue was specifying a MY_ARTIFACT_VERSION as the export. then selecting the version, should inject that var. presently does not get resolved unless i disable the security protection.

can you also throw that fix in here too?

@pmckeown

This comment has been minimized.

Copy link

pmckeown commented Nov 22, 2016

I'm affected by this problem too. The pull request looks good and was submitted 6 months ago. Please accept it onto your mainline.

@mikee805

This comment has been minimized.

Copy link
Contributor

mikee805 commented May 6, 2017

i am effected by this as well and the PR looks good to me

@mikee805 mikee805 closed this May 6, 2017
@mikee805 mikee805 mentioned this pull request May 8, 2017
0 of 9 tasks complete
@mikee805 mikee805 reopened this May 24, 2017
@mikee805 mikee805 merged commit 017193b into jenkinsci:master May 24, 2017
1 check passed
1 check passed
Jenkins This pull request looks good
Details
Copy link

aquacode left a comment

When will a new release with this change be made?

@suttermichael

This comment has been minimized.

Copy link

suttermichael commented Jan 8, 2018

When will this fix be released as a new version of the plugin?

@jgangemi

This comment has been minimized.

Copy link
Contributor

jgangemi commented Jan 24, 2018

soon 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.