Add support for pipeline #1

enwi · 2017-02-07T14:22:23Z

This pull-request fixes the folowing issues

31899
41840


        initial commit for testing Pipeline support


        added all necessary configuration options to pipeline plugin, when ru…

…nning a buildstep of rtp it just prints out all configuration as a test


        rtp now working with pipeline, but text only gets published on build …

…site not on pipeline site (todo)


        Update README.md


        workaround for showing text on pipeline page, but code still needs cl…

…eanup


        cleanup


        added missing files


        fixed all bugs and did some cleanup


        clean up, implementation of new functions, bugfixes


        bugfixes of plugin execution not covered by lifecycle configuration a…

…nd updating rtp pipeline test


        fix warning "maven-enforcer-plugin (goal "enforce") is ignored by m2e"


        bugfixes


        fix scm


        change version to 1.4


        disable injected test


        Bugfixes: "Possible null pointer dereference" and "Boxed value is unb…

…oxed and then immediately reboxed"

rodrigc · 2017-02-15T23:15:56Z

Good stuff! I downloaded your branch and installed on my system which is Jenkins 2.46 with all the latest plugins. I tried to use the Pipeline Snippet Generator to show the pipeline commands.

However the snippet generator only showed:

step <object of type org.korosoft.jenkins.plugin.rtp.RichTextPublisher>

enwi · 2017-02-16T07:48:10Z

I've got Jenkins 2.32.2 and everything works fine, but I know that when you use the snippet generator and select "step: General Build Step" and then select "Publish rich text message" the generator will show step <object of type org.korosoft.jenkins.plugin.rtp.RichTextPublisher>, because I did not implement the functionality for "General Build Steps". On the other hand you can just select "rtp" as a sample step in the snippet generator and it should generate sth. like:
rtp parserName: 'WikiText', stableText: ''
Did you try that?
Also maybe I should revise the code to make it not to show up at all in "General Build Steps".

rodrigc · 2017-02-16T08:07:24Z

Yes, you are absolutely correct.

when I selected rtp as the sample step, I saw rtp parserName: 'WikiText', stableText: ''
when I selected step: General Build Step and then Publish rich text message, then I saw <object of type org.korosoft.jenkins.plugin.rtp.RichTextPublisher>

I don't know what the convention is for implementing pipeline build steps, but
I think going in the direction to avoid confusion would be best.

enwi · 2017-02-16T08:16:03Z

Actually I just checked the code and also found this tutorial. So when you follow the tutorial the "General Build Step" should also work for rtp. I changed some code arround and will test if it will work now.

enwi · 2017-02-16T09:48:26Z

So I did a little bit of research and it seems that in "DescriptorImpl" of "RichTextPublisher" in function "FormValidation"
AbstractProject
needs to be replaced by
Job
like they did it. As well as
FilePath workspace = project.getSomeWorkspace();
by
FilePath workspace = new FilePath(project.getBuildDir());
also the null check can be removed. But this does not work for me at all.


        fix problem with workflow snippet generator where rtp could not be us…

…ed as a "General Build Step"

enwi · 2017-02-16T11:52:10Z

@rodrigc I fixed the snippet generator problem with this commit. Now you have the option to use rtp directly as a step or as a metastep ("General Build Step"), but I would always prefer to use it directly.


        fix typos in help docs and add new help docs for newly implemented fu…

…nctions


        fix typo


        fix issue [31899](https://issues.jenkins-ci.org/browse/JENKINS-31899?…

…jql=project%20%3D%20JENKINS%20AND%20component%20%3D%20rich-text-publisher-plugin)

masterhard · 2017-02-23T19:00:41Z

src/main/java/org/korosoft/jenkins/plugin/rtp/RichTextPortlet.java

            if (!useLastStable) {
                return getRichTextFromActions(project.getActions(AbstractRichTextAction.class));
            } else {
-                for (AbstractBuild<?, ?> abstractBuild : project.getBuilds()) {
+                for (Run<?, ?> build : project.getBuilds()) {


run would be a better loop variable name here

masterhard · 2017-02-23T19:00:41Z

src/main/java/org/korosoft/jenkins/plugin/rtp/RichTextPortlet.java


-                	Result res = abstractBuild.getResult();
+                	Result res = build.getResult();
                	if(res == null) {
                		throw new IllegalStateException("abstractBuild.getResult() is null!");


Exception message should be updated too


        fix loop name and exception message

enwi · 2017-02-24T08:43:53Z

@masterhard I committed your suggested changes. Let me know if there is anything else that needs to be changed. I also set the regarding issues in jira to "in review".

enwi · 2017-03-03T07:11:34Z

@masterhard Just out of curiosity when will you merge this PR ?

lechen26 · 2017-03-13T15:06:29Z

when this will be added to the pipeline?

glib-briia · 2017-04-21T08:52:43Z

Hi, Anyone got any ideas when is it going to be released?

masterhard · 2017-04-27T05:18:32Z

I'm on it. Waiting for jenkins-infra/repository-permissions-updater#291 approval now.

masterhard · 2017-04-28T06:57:59Z

Done

renfeng · 2018-11-15T01:48:25Z

Not obvious why it requires pipeline. What if someone don't want pipeline?

enwi added 16 commits Jan 26, 2017

initial commit for testing Pipeline support

be8a7de

added all necessary configuration options to pipeline plugin, when ru…

5fb43e3

…nning a buildstep of rtp it just prints out all configuration as a test

rtp now working with pipeline, but text only gets published on build …

477a041

…site not on pipeline site (todo)

Update README.md

8fdbd08

workaround for showing text on pipeline page, but code still needs cl…

dcf1174

…eanup

cleanup

f3de4d7

added missing files

fe60a3e

fixed all bugs and did some cleanup

a5f2d04

clean up, implementation of new functions, bugfixes

3ab0850

bugfixes of plugin execution not covered by lifecycle configuration a…

48ebba8

…nd updating rtp pipeline test

fix warning "maven-enforcer-plugin (goal "enforce") is ignored by m2e"

5a8a6b6

bugfixes

3accae1

fix scm

9c95fe4

change version to 1.4

Loading status checks…

2cf0f1c

disable injected test

Loading status checks…

69bfb6f

Bugfixes: "Possible null pointer dereference" and "Boxed value is unb…

Loading status checks…

9b35703

…oxed and then immediately reboxed"

fix problem with workflow snippet generator where rtp could not be us…

Loading status checks…

f1eab86

…ed as a "General Build Step"

enwi added 3 commits Feb 16, 2017

fix typos in help docs and add new help docs for newly implemented fu…

Loading status checks…

b5e5a6d

…nctions

fix typo

Loading status checks…

8a28ba4

fix issue [31899](https://issues.jenkins-ci.org/browse/JENKINS-31899?…

Loading status checks…

39511d9

…jql=project%20%3D%20JENKINS%20AND%20component%20%3D%20rich-text-publisher-plugin)

masterhard reviewed Feb 23, 2017

View changes

fix loop name and exception message

Loading status checks…

a433c9d

masterhard approved these changes Feb 24, 2017

View changes

masterhard merged commit 86ce8d8 into jenkinsci:master Mar 13, 2017
1 check passed

1 check passed

Jenkins This pull request looks good
Details

enwi deleted the enwi:recovery branch Aug 11, 2017

jenkinsci / rich-text-publisher-plugin

Add support for pipeline #1

Add support for pipeline #1

enwi commented Feb 7, 2017 •

edited

rodrigc commented Feb 15, 2017

enwi commented Feb 16, 2017 •

edited

rodrigc commented Feb 16, 2017

enwi commented Feb 16, 2017

enwi commented Feb 16, 2017 •

edited

enwi commented Feb 16, 2017 •

edited

This comment has been minimized.

This comment has been minimized.

enwi commented Feb 24, 2017

enwi commented Mar 3, 2017

lechen26 commented Mar 13, 2017 •

edited

glib-briia commented Apr 21, 2017 •

edited

masterhard commented Apr 27, 2017

masterhard commented Apr 28, 2017

This comment has been minimized.

renfeng commented on `pom.xml` in `be8a7de` Nov 15, 2018

jenkinsci / rich-text-publisher-plugin

Join GitHub today

Add support for pipeline #1

Add support for pipeline #1

Conversation

enwi commented Feb 7, 2017 • edited

rodrigc commented Feb 15, 2017

enwi commented Feb 16, 2017 • edited

rodrigc commented Feb 16, 2017

enwi commented Feb 16, 2017

enwi commented Feb 16, 2017 • edited

enwi commented Feb 16, 2017 • edited

This comment has been minimized.

masterhard Feb 23, 2017

This comment has been minimized.

masterhard Feb 23, 2017

enwi commented Feb 24, 2017

enwi commented Mar 3, 2017

lechen26 commented Mar 13, 2017 • edited

glib-briia commented Apr 21, 2017 • edited

masterhard commented Apr 27, 2017

masterhard commented Apr 28, 2017

This comment has been minimized.

renfeng commented on pom.xml in be8a7de Nov 15, 2018

enwi commented Feb 7, 2017 •

edited

enwi commented Feb 16, 2017 •

edited

enwi commented Feb 16, 2017 •

edited

enwi commented Feb 16, 2017 •

edited

lechen26 commented Mar 13, 2017 •

edited

glib-briia commented Apr 21, 2017 •

edited

renfeng commented on `pom.xml` in `be8a7de` Nov 15, 2018