Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix null pointer in addRole Service #39

Merged
merged 2 commits into from May 24, 2018

Conversation

Projects
None yet
2 participants
@PereBal
Copy link
Contributor

commented May 17, 2018

When adding the first projectRole through the addRole service, if overwrite is set to true a NullPointerException is raised. Ie:

curl JENKINS_URL/role-strategy/strategy/addRole --data "type=projectRoles&roleName=ADM&permissionIds=hudson.model.Item.Read&overwrite=true"

This PR addresses that by adding a null check before trying to replace the previous role.

@ghost

This comment has been minimized.

Copy link

commented May 24, 2018

@oleg-nenashev Should I create an issue or something like that? (Apologies for my lack of knowledge regarding how to contribute to this project)

@oleg-nenashev

This comment has been minimized.

Copy link
Member

commented May 24, 2018

@PbTG Nope, this is fine. I just missed the notification somehow. Releasing it

@oleg-nenashev oleg-nenashev merged commit 47e1f06 into jenkinsci:master May 24, 2018

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.