Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

close doGetAllRoles resp writer #41

Merged
merged 1 commit into from Aug 7, 2018

Conversation

Projects
None yet
2 participants
@runzexia
Copy link
Member

runzexia commented Jul 27, 2018

In the current version, because the writer is not closed, no response can be obtained during the actual call to the api.

@runzexia runzexia referenced this pull request Aug 1, 2018

Merged

add doGetAllRoles NPE check #40

@oleg-nenashev

This comment has been minimized.

Copy link
Member

oleg-nenashev commented Aug 7, 2018

Sorry, I have missed the notification. It is correct, the writer should be always closed

@oleg-nenashev oleg-nenashev merged commit 9dbd205 into jenkinsci:master Aug 7, 2018

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details
@runzexia

This comment has been minimized.

Copy link
Member Author

runzexia commented Aug 7, 2018

@oleg-nenashev Thank you for your review. Could you help release a new version of this plugin this week?

@runzexia runzexia deleted the runzexia:close-writer branch Aug 7, 2018

@oleg-nenashev

This comment has been minimized.

Copy link
Member

oleg-nenashev commented Aug 7, 2018

Yes. The release is in progress

@oleg-nenashev

This comment has been minimized.

Copy link
Member

oleg-nenashev commented Aug 7, 2018

Released as 2.8.2

@oleg-nenashev

This comment has been minimized.

Copy link
Member

oleg-nenashev commented Aug 7, 2018

Thanks for your contributions @runzexia !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.