Skip to content
Permalink
Browse files

Change escape to encodeURIcomponent so that plus chars are converted

correctly for s3 secret and access key

[FIXED JENKINS-13531]
  • Loading branch information
cjo9900 committed Apr 24, 2012
1 parent 510af48 commit f2caf34a52219a83768616c634279cbe59b59c36
Showing with 1 addition and 1 deletion.
  1. +1 −1 src/main/resources/hudson/plugins/s3/S3BucketPublisher/global.jelly
@@ -10,7 +10,7 @@
<f:entry title="Access key" help="/plugin/s3/help-accesskey.html">
<f:textbox name="s3.accessKey" value="${profile.accessKey}"
checkMethod="post"
checkUrl="'${rootURL}/publisher/S3BucketPublisher/loginCheck?name='+escape(Form.findMatchingInput(this,'s3.name').value)+'&amp;secretKey='+escape(Form.findMatchingInput(this,'s3.secretKey').value)+'&amp;accessKey='+escape(this.value)"
checkUrl="'${rootURL}/publisher/S3BucketPublisher/loginCheck?name='+encodeURIComponent(Form.findMatchingInput(this,'s3.name').value)+'&amp;secretKey='+encodeURIComponent(Form.findMatchingInput(this,'s3.secretKey').value)+'&amp;accessKey='+encodeURIComponent(this.value)"
/>
</f:entry>
<f:entry title="Secret key" help="/plugin/s3/help-secretkey.html">

0 comments on commit f2caf34

Please sign in to comment.
You can’t perform that action at this time.