Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JENKINS-34216 #90

Merged
merged 1 commit into from Jun 15, 2016

Conversation

Projects
None yet
2 participants
@joshuaspence
Copy link

commented Jun 9, 2016

Fixes JENKINS-34216 by following recommendations from aws/aws-sdk-java#427.

@joshuaspence

This comment has been minimized.

Copy link
Author

commented Jun 9, 2016

To test this, I created the following job:

<project>
    <description>A test for T29479.</description>
    <keepDependencies>false</keepDependencies>
    <properties></properties>
    <scm class='hudson.scm.NullSCM'></scm>
    <canRoam>true</canRoam>
    <disabled>false</disabled>
    <blockBuildWhenDownstreamBuilding>false</blockBuildWhenDownstreamBuilding>
    <blockBuildWhenUpstreamBuilding>false</blockBuildWhenUpstreamBuilding>
    <triggers class='vector'></triggers>
    <concurrentBuild>true</concurrentBuild>
    <builders>
        <hudson.tasks.Shell>
            <command>dd if=/dev/zero of=large-file bs=1M count=1024</command>
        </hudson.tasks.Shell>
    </builders>
    <publishers>
        <hudson.plugins.chucknorris.CordellWalkerRecorder>
            <factGenerator></factGenerator>
        </hudson.plugins.chucknorris.CordellWalkerRecorder>
        <hudson.plugins.s3.S3BucketPublisher>
            <profileName>REDACTED</profileName>
            <entries>
                <hudson.plugins.s3.Entry>
                    <sourceFile>large-file</sourceFile>
                    <bucket>REDACTED</bucket>
                    <storageClass>STANDARD</storageClass>
                    <selectedRegion>us-east-1</selectedRegion>
                    <noUploadOnFailure>true</noUploadOnFailure>
                    <uploadFromSlave>false</uploadFromSlave>
                    <managedArtifacts>false</managedArtifacts>
                    <useServerSideEncryption>false</useServerSideEncryption>
                    <flatten>false</flatten>
                </hudson.plugins.s3.Entry>
            </entries>
            <userMetadata></userMetadata>
        </hudson.plugins.s3.S3BucketPublisher>
    </publishers>
    <buildWrappers>
        <EnvInjectPasswordWrapper>
            <injectGlobalPasswords>true</injectGlobalPasswords>
            <maskPasswordParameters>true</maskPasswordParameters>
            <passwordEntries></passwordEntries>
        </EnvInjectPasswordWrapper>
        <org.jenkinsci.plugins.builduser.BuildUser></org.jenkinsci.plugins.builduser.BuildUser>
        <hudson.plugins.ansicolor.AnsiColorBuildWrapper>
            <colorMapName>xterm</colorMapName>
        </hudson.plugins.ansicolor.AnsiColorBuildWrapper>
        <com.michelin.cio.hudson.plugins.maskpasswords.MaskPasswordsBuildWrapper></com.michelin.cio.hudson.plugins.maskpasswords.MaskPasswordsBuildWrapper>
        <hudson.plugins.timestamper.TimestamperBuildWrapper></hudson.plugins.timestamper.TimestamperBuildWrapper>
    </buildWrappers>
    <logRotator>
        <daysToKeep>-1</daysToKeep>
        <numToKeep>-1</numToKeep>
        <artifactDaysToKeep>30</artifactDaysToKeep>
        <artifactNumToKeep>100</artifactNumToKeep>
    </logRotator>
    <scmCheckoutRetryCount>3</scmCheckoutRetryCount>
    <quietPeriod>5</quietPeriod>
</project>

Prior to my patch, this job failed 40% of the time (4 out of 10 builds).


// Set the buffer size (ReadLimit) equal to the multipart upload size,
// allowing us to resend data if the connection breaks.
request.getRequestClientOptions().setReadLimit(10485760);

This comment has been minimized.

Copy link
@Jimilian

Jimilian Jun 10, 2016

Please, extract a constant variable for this value. And it's not clear why 10485760?

This comment has been minimized.

Copy link
@joshuaspence

joshuaspence Jun 13, 2016

Author

Yeah, will do. As for the specific value, I'll be honest in saying that I am not entirely sure... I just followed the advice given at aws/aws-sdk-java#427.

@Jimilian

This comment has been minimized.

Copy link

commented Jun 10, 2016

@joshuaspence, thanks for your PR! Sorry, that didn't mention it earlier - I didn't receive update by some reason. Please, fix tiny code style issue. After that I will merge your pull request and will release new version.

@joshuaspence

This comment has been minimized.

Copy link
Author

commented Jun 13, 2016

I believe that I have addressed your feedback.

@Jimilian

This comment has been minimized.

Copy link

commented Jun 14, 2016

@joshuaspence Compilation?

Fix JENKINS-34216
Fixes JENKINS-34216 by following recommendations from aws/aws-sdk-java#427.
@joshuaspence

This comment has been minimized.

Copy link
Author

commented Jun 14, 2016

Should be good now.

@Jimilian Jimilian merged commit 3d87573 into jenkinsci:master Jun 15, 2016

1 check passed

Jenkins This pull request looks good
Details
@Jimilian

This comment has been minimized.

Copy link

commented Jun 15, 2016

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.