JENKINS-40448: add to existing actions for a run #97
Conversation
|
Sorry for delayed answer, I will double-check how same issue (multiple "actions" for 1 run) is handled by "official" plugins. I see point in your solution, but I expect (~hope) that Cloudbees will add some native support for stages in UI. In this case current solution looks like workaround. |
| @@ -66,6 +66,10 @@ public String getProfile() { | |||
| return artifacts; | |||
| } | |||
|
|
|||
| public void addArtifacts(List<FingerprintRecord> artifacts) { | |||
There was a problem hiding this comment.
This method is not needed. I'm not a Jenkins expert, but usually I'm trying to avoid creation of new public methods :)
You can use getArtifacts().addAll(). It should work as well.
|
Whoops I wasn't meant to add the test on this branch... I have the flu, wasn't sure if that was the correct place for the test. |
|
@Jimilian Let me know if the test is wrong and I can revert it for now. |
|
@juliantcook Sorry, I didn't receive any notification about your changes. Looks good for me. I will try to find some time to make this plugin more unit-test friendly :) |
|
|
||
| HtmlPage page = j.createWebClient().goTo("configure"); | ||
| WebAssert.assertTextPresent(page, "S3 profile random name"); | ||
| } | ||
|
|
||
| @Test | ||
| public void multiplePublishersUseExistingActions() throws Exception { |
There was a problem hiding this comment.
It's not best place for this test, but let's keep it as it is :)
Please let me know if this is a viable request.