[JENKINS-43507] Preach what I practice

jenkinsci · Jun 14, 2017 · 6840be21554f6da454763a95764e56cba3e74710 · 6840be2
1 parent f02bd6b
commit 6840be21554f6da454763a95764e56cba3e74710
Unified Split

Showing with 2 additions and 2 deletions.

+2 −2 docs/implementation.adoc
diff --git a/docs/implementation.adoc b/docs/implementation.adoc
@@ -570,7 +570,7 @@ public class MySCMSource extends SCMSource {
    @NonNull
    public List<SCMSourceTrait> getTraits() {
-  
-        return new ArrayList<>(traits);
+  
+        return Collections.unmodifiableList(traits);
    }
    @DataBoundSetter
@@ -1106,7 +1106,7 @@ public class MySCMNavigator extends SCMNavigator {
    @NonNull
    public List<SCMTrait<?>> getTraits() {
-  
-        return new ArrayList<>(traits);
+  
+        return Collections.unmodifiableList(traits);
    }
    @DataBoundSetter