Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the plugin Java 11 ready -- Remove JAXB usage #63

Merged
merged 7 commits into from Mar 21, 2019

Conversation

Projects
None yet
5 participants
@batmat
Copy link
Member

commented Mar 21, 2019

mvn -V clean verify -Djenkins.version=2.164.1 works with this fix, both on a JDK8 and JDK11.

@jenkinsci/java11-support

Bump to Java 8 min, so building with Jenkins 2.164 works
`mvn -V clean verify -Djenkins.version=2.164.1` works with this fix.
@casz

casz approved these changes Mar 21, 2019

@batmat

This comment has been minimized.

Copy link
Member Author

commented Mar 21, 2019

infra issue...

@batmat batmat closed this Mar 21, 2019

@batmat batmat reopened this Mar 21, 2019

Fix FindBugs failure
```
INFO] --- spotbugs-maven-plugin:3.1.11:check (spotbugs) @ scm-api ---
[INFO] BugInstance size is 1
[INFO] Error size is 0
[INFO] Total bugs: 1
[ERROR] jenkins.scm.impl.form.NamedArrayList doesn't override java.util.ArrayList.equals(Object) [jenkins.scm.impl.form.NamedArrayList] At NamedArrayList.java:[line 1] EQ_DOESNT_OVERRIDE_EQUALS
[INFO]
```

@batmat batmat changed the title [WIP] Bump to Java 8 min, so building with Jenkins 2.164 works Make the plugin Java 11 ready -- Remove JAXB usage Mar 21, 2019

@casz

casz approved these changes Mar 21, 2019

@batmat

This comment has been minimized.

Copy link
Member Author

commented Mar 21, 2019

@stephenc It is ready for your review, and hopefully approval & merge :). Thanks!

@batmat

This comment has been minimized.

Copy link
Member Author

commented Mar 21, 2019

@stephenc
Copy link
Member

left a comment

Next version needs to have at least a minor bump

Show resolved Hide resolved pom.xml Outdated

batmat added some commits Mar 21, 2019

Bumping next version as requested by maintainer
@stephenc is requesting this to signal the fact the next version might
be slightly more than just a minor one in terms of risk, I gather.
@batmat

This comment has been minimized.

Copy link
Member Author

commented Mar 21, 2019

@stephenc comment addressed, and conflict with master fixed.

@stephenc stephenc merged commit bbf9667 into jenkinsci:master Mar 21, 2019

2 checks passed

continuous-integration/jenkins/incrementals Deployed to Incrementals.
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details

@batmat batmat deleted the batmat:java11-readiness branch Mar 21, 2019

@batmat

This comment has been minimized.

Copy link
Member Author

commented Mar 21, 2019

Thanks Stephen!

@stephenc

This comment has been minimized.

Copy link
Member

commented on 3046df1 Mar 21, 2019

Actually a Jenkins core version bump is something I prefer to signal with minor.

@drdamour

This comment has been minimized.

Copy link

commented Mar 27, 2019

@stephenc i think the release notes on https://plugins.jenkins.io/scm-api have a typo they say required 2.160.3 not 2.60.3

@drdamour

This comment has been minimized.

Copy link

commented Mar 27, 2019

Screen Shot 2019-03-26 at 6 47 09 PM

@casz

This comment has been minimized.

Copy link
Member

commented Mar 27, 2019

@drdamour anyone can fix that typo as long as you have a Jenkins account. https://accounts.jenkins.io/signup

On the plugins page to the right you should see the text: ARE YOU MAINTAINING THIS PLUGIN? Visit the Jenkins Plugin Wiki to edit this content.
The link takes you to https://wiki.jenkins.io/display/JENKINS/SCM+API+Plugin

Where you can sign in with your Jenkins account

However I have fixed the typo for now 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.