Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-34599] Setting of final fields #132

Merged
merged 12 commits into from Jul 25, 2017

Conversation

Projects
None yet
4 participants
@jglick
Copy link
Member

jglick commented Jul 11, 2017

@reviewbybees

This comment has been minimized.

Copy link

reviewbybees commented Jul 11, 2017

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@abayer

abayer approved these changes Jul 18, 2017

@oleg-nenashev
Copy link
Member

oleg-nenashev left a comment

The code LGTM, didn't test it

@jglick jglick merged commit a737597 into jenkinsci:master Jul 25, 2017

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details

@jglick jglick deleted the jglick:final-fields-JENKINS-34599 branch Jul 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.