Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-46088] Verify removal of double transform of cast expression #139

Merged
merged 4 commits into from Aug 16, 2017

Conversation

@abayer
Copy link
Member

abayer commented Aug 9, 2017

@reviewbybees

This comment has been minimized.

Copy link

reviewbybees commented Aug 9, 2017

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

Copy link
Member

oleg-nenashev left a comment

🐝 once upstream is ready

Copy link
Member

jglick left a comment

As a test, fine. The upstream PR is another matter. And this might be able to remove

staticMethod org.kohsuke.groovy.sandbox.impl.Checker checkedCast java.lang.Class java.lang.Object boolean boolean boolean
@jglick
jglick approved these changes Aug 16, 2017
@abayer abayer merged commit 7a81a07 into jenkinsci:master Aug 16, 2017
1 check passed
1 check passed
continuous-integration/jenkins/pr-merge This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.