Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-34741] Reproduced problem in test #67

Merged
merged 2 commits into from May 11, 2016

Conversation

Projects
None yet
4 participants
@jglick
Copy link
Member

jglick commented May 6, 2016

JENKINS-34741

@oleg-nenashev passed on a report of this. Not yet obvious to me how to fix, but useful to have the test case recorded.

@reviewbybees

@reviewbybees

This comment has been minimized.

Copy link

reviewbybees commented May 6, 2016

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@abayer

This comment has been minimized.

Copy link
Member

abayer commented May 9, 2016

🐝 Yeah, short of whitelisting named parameter constructors in a blanket way, I'm not sure what the solution would be.

@jglick

This comment has been minimized.

Copy link
Member Author

jglick commented May 9, 2016

According to this the sandbox should be checking whitelists for the default constructor and then all mentioned setters (or I guess field accesses).

Yet another case of the sandbox not telling us what it is really running; cf. jenkinsci/groovy-sandbox#7.

@oleg-nenashev

This comment has been minimized.

Copy link
Member

oleg-nenashev commented May 9, 2016

🐝, but we need to create a JIRA issues and reference it before merging

@jglick jglick changed the title Reproduced problem in test [JENKINS-34741] Reproduced problem in test May 11, 2016

@jglick jglick merged commit ac5d5bf into jenkinsci:master May 11, 2016

1 check passed

Jenkins This pull request looks good
Details

@jglick jglick deleted the jglick:structConstructor branch May 11, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.