Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blacklisting RunWrapper.getRawBuild #69

Merged
merged 1 commit into from May 19, 2016

Conversation

@jglick
Copy link
Member

commented May 18, 2016

currentBuild.rawBuild is not in and of itself a risk in a Pipeline script, but pretty much anything you would do with the result would be, so best to nip this in the bud.

@reviewbybees

@reviewbybees

This comment has been minimized.

Copy link

commented May 18, 2016

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@@ -22,3 +22,6 @@ staticMethod org.codehaus.groovy.runtime.DefaultGroovyMethods execute java.lang.
staticMethod org.codehaus.groovy.runtime.DefaultGroovyMethods execute java.util.List
staticMethod org.codehaus.groovy.runtime.DefaultGroovyMethods execute java.util.List java.lang.String[] java.io.File
staticMethod org.codehaus.groovy.runtime.DefaultGroovyMethods execute java.util.List java.util.List java.io.File

# TODO do we need a @Blacklisted annotation?

This comment has been minimized.

Copy link
@svanoort

svanoort May 19, 2016

Member

That would be nice, yes.

@svanoort

This comment has been minimized.

Copy link
Member

commented May 19, 2016

🐝

@andresrc

This comment has been minimized.

Copy link

commented May 19, 2016

🐝

@alvarolobato

This comment has been minimized.

Copy link
Member

commented May 19, 2016

🐝

@daniel-beck

This comment has been minimized.

Copy link
Member

commented May 19, 2016

Does this need a compatibility warning? What happens when it's already whitelisted?

@jglick

This comment has been minimized.

Copy link
Member Author

commented May 19, 2016

What happens when it's already whitelisted?

ALL YOUR JENKINS HOME BELONG TO US

@jglick

This comment has been minimized.

Copy link
Member Author

commented May 19, 2016

(well…no, but you should have known better)

@jglick jglick merged commit 155ac3d into jenkinsci:master May 19, 2016

1 check passed

Jenkins This pull request looks good
Details

@jglick jglick deleted the jglick:RunWrapper.getRawBuild branch May 19, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.