Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable shortcut key #6

Closed
wants to merge 2 commits into from
Closed

Enable shortcut key #6

wants to merge 2 commits into from

Conversation

ikikko
Copy link
Member

@ikikko ikikko commented Feb 18, 2012

I added a shortcut key to submit on script console, and generalized it to use on other places [1].
Later I integrate the shortcut key into Scripler Plugin.

In the process of integration, I notice that json paramter does not submitted with shortcut key.
So, I replaced json with raw request parameter, in "ScriptlerManagment#extractParameters()" method.

[1] jenkinsci/jenkins#364

@imod
Copy link
Member

imod commented Feb 21, 2012

ok, I see...
I just don't feel comfortable to lift that dependency, after all only people installing the shortcut plugin will have advantage with this.
Don't take me wrong I do really see the value in it. But maybe we can change in a way that people having the shortcut plugin installed have advantages but everyone else does not have any negative impacts.
Every lift of the core dependency removes the chance that people using the LTS can use this plugin in the near future :(

@ikikko
Copy link
Member Author

ikikko commented Feb 23, 2012

ok, I think so too.
When this pull request is merged now, there is a big negative impact which cannot be ignored.

But, In addition, if scriptler plugin uses script console editor through core module once,
we can use on scriptler not only shortcut key but other features which will be added in core.

I'm looking forward to being merged in the future.
Thanks!

@imod
Copy link
Member

imod commented Feb 23, 2012

I sure will - I promise :)

imod added a commit that referenced this pull request Aug 31, 2012
@imod
Copy link
Member

imod commented Aug 31, 2012

merged in 202584a
will be in next release: 2.4

@imod imod closed this Aug 31, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants