Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JENKINS-52781] Filter symlinks out when shelving a project #19

Merged
merged 1 commit into from Jul 13, 2019
Merged

[JENKINS-52781] Filter symlinks out when shelving a project #19

merged 1 commit into from Jul 13, 2019

Conversation

PierreBtz
Copy link
Contributor

CC @reviewbybees

jglick
jglick approved these changes Jun 17, 2019
View reviewed changes
Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a five-second review, sounds good!

@jglick
Copy link
Member

jglick commented Jun 17, 2019

compare jenkinsci/jenkins#3982

oleg-nenashev
oleg-nenashev approved these changes Jun 19, 2019
View reviewed changes
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, and thanks for tests!

@PierreBtz PierreBtz added the bug label Jul 13, 2019
@PierreBtz PierreBtz merged commit 1f4442c into jenkinsci:master Jul 13, 2019
@PierreBtz PierreBtz deleted the pbeitz/JENKINS-52781 branch July 13, 2019 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jglick jglick jglick approved these changes

@oleg-nenashev oleg-nenashev oleg-nenashev approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
3 participants
@PierreBtz @jglick @oleg-nenashev