Skip to content
Permalink
Browse files
[JENKINS-21700] Sorting using Distribution column/graph doesn't work
- If table header Distribution on report page is clicked, the rows will be sorted randomly.
- The rows are now sorted according to the lines count.
- data="0" in tfoot row is needed for proper sorting (unknown why).
  • Loading branch information
mixalturek committed Feb 6, 2014
1 parent 37bc407 commit 9a35e83da06796ec45d518cbf6a0349d48ec38e3
Showing 4 changed files with 8 additions and 8 deletions.
@@ -21,7 +21,7 @@
<td class="pane">${container.language}</td>
<td class="pane">${container.part}</td>
<td class="pane number" data="${container.lineCount}">${container.lineCountString}</td>
<td class="pane"><st:include page="/tabview/distribution-graph.jelly" /></td>
<td class="pane" data="${container.lineCount}"><st:include page="/tabview/distribution-graph.jelly" /></td>
</tr>
</j:forEach>
</tbody>
@@ -31,7 +31,7 @@
<td class="pane-header"> </td>
<td class="pane-header"> </td>
<td class="pane-header number" data="${cachedReport.lineCount}">${cachedReport.lineCountString}</td>
<td class="pane-header"> </td>
<td class="pane-header" data="0"> </td>
</tr>
</tfoot>
</table>
@@ -19,7 +19,7 @@
<td class="pane"><a href="folderResult/${container.urlName}">${container.name}</a></td>
<td class="pane number" data="${container.fileCount}">${container.fileCountString}</td>
<td class="pane number" data="${container.lineCount}">${container.lineCountString}</td>
<td class="pane"><st:include page="/tabview/distribution-graph.jelly" /></td>
<td class="pane" data="${container.lineCount}"><st:include page="/tabview/distribution-graph.jelly" /></td>
</tr>
</j:forEach>
</tbody>
@@ -28,7 +28,7 @@
<td class="pane-header">${%Total} ${cachedReport.folderCountString}</td>
<td class="pane-header number" data="${cachedReport.fileCount}">${cachedReport.fileCountString}</td>
<td class="pane-header number" data="${cachedReport.lineCount}">${cachedReport.lineCountString}</td>
<td class="pane-header"> </td>
<td class="pane-header" data="0"> </td>
</tr>
</tfoot>
</table>
@@ -19,7 +19,7 @@
<td class="pane"><a href="languageResult/${container.name}">${container.name}</a></td>
<td class="pane number" data="${container.fileCount}">${container.fileCountString}</td>
<td class="pane number" data="${container.lineCount}">${container.lineCountString}</td>
<td class="pane"><st:include page="/tabview/distribution-graph.jelly" /></td>
<td class="pane" data="${container.lineCount}"><st:include page="/tabview/distribution-graph.jelly" /></td>
</tr>
</j:forEach>
</tbody>
@@ -28,7 +28,7 @@
<td class="pane-header">${%Total} ${cachedReport.languageCountString}</td>
<td class="pane-header number" data="${cachedReport.fileCount}">${cachedReport.fileCountString}</td>
<td class="pane-header number" data="${cachedReport.lineCount}">${cachedReport.lineCountString}</td>
<td class="pane-header"> </td>
<td class="pane-header" data="0"> </td>
</tr>
</tfoot>
</table>
@@ -19,7 +19,7 @@
<td class="pane"><a href="partResult/${container.name}">${container.name}</a></td>
<td class="pane number" data="${container.fileCount}">${container.fileCountString}</td>
<td class="pane number" data="${container.lineCount}">${container.lineCountString}</td>
<td class="pane"><st:include page="/tabview/distribution-graph.jelly" /></td>
<td class="pane" data="${container.lineCount}"><st:include page="/tabview/distribution-graph.jelly" /></td>
</tr>
</j:forEach>
</tbody>
@@ -28,7 +28,7 @@
<td class="pane-header">${%Total} ${cachedReport.partCountString}</td>
<td class="pane-header number" data="${cachedReport.fileCount}">${cachedReport.fileCountString}</td>
<td class="pane-header number" data="${cachedReport.lineCount}">${cachedReport.lineCountString}</td>
<td class="pane-header"> </td>
<td class="pane-header" data="0"> </td>
</tr>
</tfoot>
</table>

0 comments on commit 9a35e83

Please sign in to comment.