Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-30561] Attempt to install JDK if min java requirements are not met #40

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@e-g-hategan
Copy link

commented Dec 19, 2016

@oleg-nenashev
Copy link
Member

left a comment

🐛 since it cancels the support of Java 6 on the plugin, which targets 1.609.x core. If we want to do in such way, the core dep should be bumped (CC @olivergondza )

@e-g-hategan

This comment has been minimized.

Copy link
Author

commented Mar 13, 2017

Just clarifying: do you mean I should bump jenkins.version to latest 2.50, java.level to 7 and address any upgrade related issues?

@oleg-nenashev

This comment has been minimized.

Copy link
Member

commented Mar 13, 2017

Definitely not to 2.50. I am not sure what should be used exactly. credentials plugin dependency in the plugin already requires 1.625.3, hence I doubt this plugin actually can support Java6 anyway (CC @daniel-beck, @olivergondza , @stephenc since they are involved into the related changes).

So I suppose 1.625.3 is the best possible target

@@ -1176,6 +1178,10 @@ protected String checkJavaVersion(final PrintStream logger, String javaCommand,
return null;
}

private double requiredJavaVersion() {
return Double.valueOf("1." + JDK_MAJOR_VERSION);

This comment has been minimized.

Copy link
@olivergondza

olivergondza Mar 15, 2017

Member

How about base this on a minimal version that is supported by jenkins version running on master (provided we can get that information at runtime)? Or at least use the version running on master as the minimum.

This comment has been minimized.

Copy link
@e-g-hategan

e-g-hategan Mar 15, 2017

Author

That's a good idea.

This comment has been minimized.

Copy link
@oleg-nenashev

oleg-nenashev Mar 15, 2017

Member

It can be hardcoded by checking the remoting version

This comment has been minimized.

Copy link
@e-g-hategan

e-g-hategan Mar 15, 2017

Author

Based on Jenkins.getInstance().getVersion() we have 3 possible outcomes:
before 1.610 then java 6
before 2.5x: java 7
afterwards java 8 (will happen soon; confirmed on the IRC channel).

This comment has been minimized.

Copy link
@oleg-nenashev

oleg-nenashev Mar 15, 2017

Member

Something like that. But I am not sure this plugin can wok on Java 6 due to the credentials dependency

This comment has been minimized.

Copy link
@monkz

monkz Apr 12, 2017

Contributor

as jenkins.io offers a jdk list - i recommend using this list to choose a JDK version

@e-g-hategan e-g-hategan deleted the e-g-hategan:master branch Dec 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.