Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX JENKINS-51876] inform about using a deprecated constructor #91

Merged
merged 8 commits into from Jul 23, 2018
Merged

[FIX JENKINS-51876] inform about using a deprecated constructor #91

merged 8 commits into from Jul 23, 2018

Conversation

kuisathaverat
Copy link
Contributor

JENKINS-51876

  • Adds a log message on deprecated constructors
  • Deprecate constructor that should be deprecated also

jeffret-b
jeffret-b reviewed Jul 20, 2018
View reviewed changes
Copy link

@jeffret-b jeffret-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to go even further and just remove the ones that have been deprecated for a long time?

Otherwise, I think it looks good.

@kuisathaverat
Copy link
Contributor Author

my idea, it is to keep them for a couple of version and start to remove the old ones.

@kuisathaverat kuisathaverat mentioned this pull request Jul 21, 2018
Merged
@kuisathaverat kuisathaverat merged commit f540572 into jenkinsci:master Jul 23, 2018
@kuisathaverat kuisathaverat changed the title [JENKINS-51876] inform about using a deprecated constructor [FIX JENKINS-51876] inform about using a deprecated constructor Aug 14, 2018
@kuisathaverat kuisathaverat deleted the JENKINS-51876 branch March 10, 2019 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffret-b jeffret-b jeffret-b approved these changes

@jvz jvz Awaiting requested review from jvz

@dwnusbaum dwnusbaum Awaiting requested review from dwnusbaum

@varyvol varyvol Awaiting requested review from varyvol

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
2 participants
@kuisathaverat @jeffret-b