New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED JENKINS-34464] Enable DescribableModel binding for Result #19

Merged
merged 1 commit into from May 24, 2017

Conversation

Projects
None yet
4 participants
@abayer
Member

abayer commented May 22, 2017

@abayer abayer requested a review from jglick May 22, 2017

@reviewbybees

This comment has been minimized.

Show comment
Hide comment
@reviewbybees

reviewbybees May 22, 2017

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

reviewbybees commented May 22, 2017

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@jglick

jglick approved these changes May 22, 2017

Looks good. Recommend an integration test, say in org.jenkinsci.plugins.workflow.job.ReverseBuildTriggerTest. Also desire a patch to ReverseBuildTrigger to use @DataBoundSetter.

@oleg-nenashev

🐝 LGTM

@abayer abayer merged commit 8d0f4ad into jenkinsci:master May 24, 2017

1 check passed

Jenkins This pull request looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment