Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempting to analyze ChoiceParameterDefinition.choices just causes the world to explode #41

Merged
merged 1 commit into from Oct 4, 2018

Conversation

Projects
None yet
3 participants
@jglick
Copy link
Member

jglick commented Oct 3, 2018

jenkinsci/jenkins#3014 breaks basic assumptions. Anything trying to create a model of something taking parameters (say, the input step) spins off into space analyzing every Describable known.

@jglick jglick requested review from abayer , rsandell , dwnusbaum , daniel-beck and svanoort Oct 3, 2018

@abayer

abayer approved these changes Oct 3, 2018

jglick added a commit to jglick/workflow-cps-plugin that referenced this pull request Oct 3, 2018

@jglick jglick merged commit 45de773 into jenkinsci:master Oct 4, 2018

2 checks passed

continuous-integration/jenkins/incrementals Deployed to Incrementals.
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details

@jglick jglick deleted the jglick:ChoiceParameterDefinition.choices branch Oct 4, 2018

@daniel-beck

This comment has been minimized.

Copy link
Member

daniel-beck commented Oct 5, 2018

jglick added a commit to jglick/structs-plugin that referenced this pull request Oct 5, 2018

jglick added a commit that referenced this pull request Oct 5, 2018

Merge pull request #42 from jglick/ChoiceParameterDefinition-JENKINS-…
…53917

[JENKINS-53917] Reverting #41 as it broke binding of ChoiceParameterDefinition in scripts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.