Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore Commits only consisting of changed properties on dirs. #14

Merged
merged 5 commits into from Nov 22, 2012

Conversation

@pauxus
Copy link
Contributor

commented Aug 3, 2012

  • introduced a new property (checkbox)
  • changed XMLParser to include "kind" attribute into changelog
  • paths containing kind:dir and action:M (which must be a property
    change)
    are ignored during notifyCommit and not part of SCM.ChangeLog,
    i.e. they are ignored in Maven Builds.

This is useful for Incremental Builds in Maven in a branch that is target of merges (i.e.: trunk). Without that this modification consider a project of 100 modules. Every merge (even a "block-revision" merge, that doesn't change any files) changes the top directory of the project (svn:mergeinfo), i.e. from the perspective of Jenkins, the aggregator project has changed (which is usually inherited by all modules). Jenkins thus includes the aggregator in the list of changed modules and ALL modules are build.

When doing frequent merges this results in continual rebuild of the whole project, totally negating the advantages of incremental builds.

This pull request allows to exclude property-only changes on directories from:

  • the SCM-Polling (i.e. a change that only consists of property changes on directories does not result in a new build)
  • the changelog used by MavenModuleSet when calculating the changed modules of a new revision.

A changed path is considered Property Only when it consists of a "M"odified Action on a directory.

- introduced a new property (checkbox)
- changed XMLParser to include "kind" attribute into changelog
- paths containing kind:dir and action:M (which must be a property
change)
  are ignored during notifyCommit and not part of SCM.ChangeLog,
  i.e. they are ignored in Maven Builds.
@pauxus

This comment has been minimized.

Copy link
Contributor Author

commented Aug 3, 2012

a more complete unit test is under way

@buildhive

This comment has been minimized.

Copy link

commented Aug 3, 2012

Jenkins » subversion-plugin #21 UNSTABLE
Looks like there's a problem with this pull request
(what's this?)

@tbingaman

This comment has been minimized.

Copy link
Member

commented Aug 3, 2012

sweet, this would be really useful for avoiding pointless rebuilds of Ivy incremental builds too.

@buildhive

This comment has been minimized.

Copy link

commented Aug 4, 2012

Jenkins » subversion-plugin #22 UNSTABLE
Looks like there's a problem with this pull request
(what's this?)

@buildhive

This comment has been minimized.

Copy link

commented on 076759d Aug 4, 2012

Jenkins » subversion-plugin #22 UNSTABLE
Looks like this commit caused a build failure
(what's this?)

Due to an intolerant parsing of URLs by SVNKit
@buildhive

This comment has been minimized.

Copy link

commented Aug 4, 2012

Jenkins » subversion-plugin #23 UNSTABLE
Looks like there's a problem with this pull request
(what's this?)

@buildhive

This comment has been minimized.

Copy link

commented on 784629e Aug 4, 2012

Jenkins » subversion-plugin #23 UNSTABLE
Looks like this commit caused a build failure
(what's this?)

@buildhive

This comment has been minimized.

Copy link

commented Aug 4, 2012

Jenkins » subversion-plugin #24 UNSTABLE
Looks like there's a problem with this pull request
(what's this?)

@buildhive

This comment has been minimized.

Copy link

commented on 564c974 Aug 4, 2012

Jenkins » subversion-plugin #24 UNSTABLE
Looks like this commit caused a build failure
(what's this?)

@kutzi

This comment has been minimized.

What should be fixed here?

This comment has been minimized.

Copy link
Owner Author

replied Aug 5, 2012

Ups, that was a copy - paste from the original handler.mI will remove it.

@buildhive

This comment has been minimized.

Copy link

commented Aug 5, 2012

Jenkins » subversion-plugin #25 SUCCESS
This pull request looks good
(what's this?)

@pauxus

This comment has been minimized.

Copy link
Contributor Author

commented Aug 5, 2012

@pauxus

This comment has been minimized.

Copy link
Contributor Author

commented Sep 17, 2012

Anything new on this request? What needs to be done to merge it? (FYI: We are using the patched version of subversion plugin for over a month now without any problems)

@twilde

This comment has been minimized.

Copy link

commented Oct 5, 2012

+1 to this feature

@kutzi

This comment has been minimized.

Typo 'onyl' instead of 'only'.

@kutzi kutzi merged commit 789bb7e into jenkinsci:master Nov 22, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.