[JENKINS-48543] Remove agent-to-controller calls #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jglick
changed the title
jglick
commented
Nov 10, 2021
| @@ -2692,8 +2692,7 @@ public static void init() {} | |||
| System.setProperty("svnkit.http.methods","Digest,Basic,NTLM,Negotiate"); | |||
|
|
|||
| // use SVN1.4 compatible workspace by default. | |||
| SVNAdminAreaFactory.setSelector(new SubversionWorkspaceSelector()); | |||
| } | |||
| SVNAdminAreaFactory.setSelector(new SubversionWorkspaceSelector(workspaceFormat)); | |||
There was a problem hiding this comment.
This part is tricky. SVNKit apparently has static state, which is a bad idea generally (forces us to do some work on both the Jenkins controller & agent JVMs) and is especially weird since there is a user-configurable format which we have to somehow pass into static state. Hope test coverage is good enough here.
|
@didiez can you review this please? I can spend the time to fix up merge conflicts if someone is going to acknowledge that this exists. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JENKINS-48543
Following up 7d1525e to reduce risk and complexity, and provide compatibility with possible future hardenings such as jenkinsci/jenkins#5885. Not tested beyond what automated test coverage exists here.