Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED JENKINS-18534] equals()/hashCode() for parameter value #87

Merged
merged 2 commits into from Jul 2, 2014

Conversation

@daniel-beck
Copy link
Member

commented Jun 17, 2014

The default implementation considers parameters with the same name
to be identical, resulting in queue items being collapsed.

With this change, different values for a parameter will result in
different builds.

The default implementation considers parameters with the same name
to be identical, resulting in queue items being collapsed.

With this change, different values for a parameter will result in
different builds.
@cloudbees-pull-request-builder

This comment has been minimized.

Copy link

commented Jun 17, 2014

plugins » subversion-plugin #381 SUCCESS
This pull request looks good

@jenkinsadmin

This comment has been minimized.

Copy link
Member

commented Jun 18, 2014

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@oleg-nenashev

This comment has been minimized.

Copy link
Member

commented Jun 19, 2014

👍

@christ66

This comment has been minimized.

Copy link
Member

commented Jun 24, 2014

I don't know how to merge this into the pull request, but here's a test unit for your equals and hashcode implementations: https://gist.github.com/christ66/681360067d6a71e043d5.

@cloudbees-pull-request-builder

This comment has been minimized.

Copy link

commented Jun 30, 2014

plugins » subversion-plugin #383 UNSTABLE
Looks like there's a problem with this pull request

@daniel-beck

This comment has been minimized.

Copy link
Member Author

commented Jun 30, 2014

I don't see how the failure could be related to this PR.

oleg-nenashev added a commit that referenced this pull request Jul 2, 2014
[FIXED JENKINS-18534] equals()/hashCode() for parameter value
@oleg-nenashev oleg-nenashev merged commit 7fecc42 into jenkinsci:master Jul 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.