Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED JENKINS-49931] Heap Histogram Collection Destabilizes Masters #134

Merged
merged 1 commit into from Mar 6, 2018

Conversation

@escoem
Copy link
Contributor

commented Mar 6, 2018

https://issues.jenkins-ci.org/browse/JENKINS-49931

@svanoort @reviewbybees please review.

Now the histogram is disabled by default, thus you will need to enable it either adding a system property -Dcom.cloudbees.jenkins.support.impl.HeapUsageHistogram.DISABLED=false or running from Script Console the line com.cloudbees.jenkins.support.impl.HeapUsageHistogram.DISABLED=false

Yes, the system property and the direct assignment have the same path/name.

@svanoort svanoort merged commit bb6eb98 into jenkinsci:master Mar 6, 2018

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details
@@ -33,6 +33,10 @@
// first 200 classes so 203 lines required because of the header
private static final int MAX = 203;

// disabled by default because of JENKINS-49931
// to be reviewed in the future.
private static /*final*/ boolean DISABLED = Boolean.parseBoolean(System.getProperty(HeapUsageHistogram.class.getCanonicalName() + ".DISABLED", "true"));

This comment has been minimized.

Copy link
@jglick

jglick Mar 7, 2018

Member

BTW use of the negative sense is discouraged. Rather use ENABLED and default to false.

Also use SystemProperties since we are on Jenkins 2.x now.

This comment has been minimized.

Copy link
@escoem

escoem Mar 8, 2018

Author Contributor

@jglick thanks! I will use ENABLE instead of DISABLE in the future. I have created the https://issues.jenkins-ci.org/browse/JENKINS-50010 in order to let admins enable/disable components through UI, and also a common way to enforce the disable of components as a system property.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.