Verifying full stack traces in deadlocks

[jglick]

Saw a support bundle from someone presumably using this plugin <2.28 and was annoyed by a deadlock file which hinted at JENKINS-31614 yet lacked the crucial detail of the caller of Queue.schedule.
#41 seems to have fixed this, but included no test addition to prove it. Doing so now.

I originally fixed this against an older version of the plugin using the methods already available in Functions in Jenkins core. For some reason these do not seem to be showing full lock information in this context, though. Original display:

==============
Deadlock Found
==============
"Thread-12" Id=45 BLOCKED on java.lang.Object@7c60aaa5 owned by "Thread-11" Id=44
    at com.cloudbees.jenkins.support.timer.DeadlockTest$2.run(DeadlockTest.java:78)
    -  blocked on java.lang.Object@7c60aaa5
    at java.lang.Thread.run(Thread.java:745)


"Thread-11" Id=44 BLOCKED on java.lang.Object@72a74b59 owned by "Thread-12" Id=45
    at com.cloudbees.jenkins.support.timer.DeadlockTest$1.secondMethod(DeadlockTest.java:69)
    -  blocked on java.lang.Object@72a74b59
    at com.cloudbees.jenkins.support.timer.DeadlockTest$1.secondMethod(DeadlockTest.java:67)
    at com.cloudbees.jenkins.support.timer.DeadlockTest$1.secondMethod(DeadlockTest.java:67)
    at com.cloudbees.jenkins.support.timer.DeadlockTest$1.secondMethod(DeadlockTest.java:67)
    at com.cloudbees.jenkins.support.timer.DeadlockTest$1.secondMethod(DeadlockTest.java:67)
    at com.cloudbees.jenkins.support.timer.DeadlockTest$1.secondMethod(DeadlockTest.java:67)
    at com.cloudbees.jenkins.support.timer.DeadlockTest$1.secondMethod(DeadlockTest.java:67)
    at com.cloudbees.jenkins.support.timer.DeadlockTest$1.secondMethod(DeadlockTest.java:67)
    ...

After my initial attempt:

==============
Deadlock Found
==============
"Thread-11" Id=44 Group=main BLOCKED on java.lang.Object@76f6d06b owned by "Thread-12" Id=45
    at com.cloudbees.jenkins.support.timer.DeadlockTest$1.secondMethod(DeadlockTest.java:69)
    -  blocked on java.lang.Object@76f6d06b
    at com.cloudbees.jenkins.support.timer.DeadlockTest$1.secondMethod(DeadlockTest.java:67)
    at com.cloudbees.jenkins.support.timer.DeadlockTest$1.secondMethod(DeadlockTest.java:67)
    at com.cloudbees.jenkins.support.timer.DeadlockTest$1.secondMethod(DeadlockTest.java:67)
    at com.cloudbees.jenkins.support.timer.DeadlockTest$1.secondMethod(DeadlockTest.java:67)
    at com.cloudbees.jenkins.support.timer.DeadlockTest$1.secondMethod(DeadlockTest.java:67)
    at com.cloudbees.jenkins.support.timer.DeadlockTest$1.secondMethod(DeadlockTest.java:67)
    at com.cloudbees.jenkins.support.timer.DeadlockTest$1.secondMethod(DeadlockTest.java:67)
    at com.cloudbees.jenkins.support.timer.DeadlockTest$1.secondMethod(DeadlockTest.java:67)
    at com.cloudbees.jenkins.support.timer.DeadlockTest$1.secondMethod(DeadlockTest.java:67)
    at com.cloudbees.jenkins.support.timer.DeadlockTest$1.secondMethod(DeadlockTest.java:67)
    at com.cloudbees.jenkins.support.timer.DeadlockTest$1.secondMethod(DeadlockTest.java:67)
    at com.cloudbees.jenkins.support.timer.DeadlockTest$1.secondMethod(DeadlockTest.java:67)
    at com.cloudbees.jenkins.support.timer.DeadlockTest$1.secondMethod(DeadlockTest.java:67)
    at com.cloudbees.jenkins.support.timer.DeadlockTest$1.secondMethod(DeadlockTest.java:67)
    at com.cloudbees.jenkins.support.timer.DeadlockTest$1.secondMethod(DeadlockTest.java:67)
    at com.cloudbees.jenkins.support.timer.DeadlockTest$1.secondMethod(DeadlockTest.java:67)
    at com.cloudbees.jenkins.support.timer.DeadlockTest$1.secondMethod(DeadlockTest.java:67)
    at com.cloudbees.jenkins.support.timer.DeadlockTest$1.secondMethod(DeadlockTest.java:67)
    at com.cloudbees.jenkins.support.timer.DeadlockTest$1.secondMethod(DeadlockTest.java:67)
    at com.cloudbees.jenkins.support.timer.DeadlockTest$1.secondMethod(DeadlockTest.java:67)
    at com.cloudbees.jenkins.support.timer.DeadlockTest$1.firstMethod(DeadlockTest.java:63)
    at com.cloudbees.jenkins.support.timer.DeadlockTest$1.run(DeadlockTest.java:59)
    at java.lang.Thread.run(Thread.java:745)


"Thread-12" Id=45 Group=main BLOCKED on java.lang.Object@28e9c20a owned by "Thread-11" Id=44
    at com.cloudbees.jenkins.support.timer.DeadlockTest$2.run(DeadlockTest.java:78)
    -  blocked on java.lang.Object@28e9c20a
    at java.lang.Thread.run(Thread.java:745)

Current plugin output:

==============
Deadlock Found
==============
"Thread-12" id=45 (0x2d) state=BLOCKED cpu=0%
    - waiting to lock <0x3847f429> (a java.lang.Object)
      owned by "Thread-11" id=44 (0x2c)
    at com.cloudbees.jenkins.support.timer.DeadlockTest$2.run(DeadlockTest.java:81)
    at java.lang.Thread.run(Thread.java:745)

"Thread-11" id=44 (0x2c) state=BLOCKED cpu=0%
    - waiting to lock <0x40826664> (a java.lang.Object)
      owned by "Thread-12" id=45 (0x2d)
    at com.cloudbees.jenkins.support.timer.DeadlockTest$1.secondMethod(DeadlockTest.java:72)
    at com.cloudbees.jenkins.support.timer.DeadlockTest$1.secondMethod(DeadlockTest.java:70)
    at com.cloudbees.jenkins.support.timer.DeadlockTest$1.secondMethod(DeadlockTest.java:70)
    at com.cloudbees.jenkins.support.timer.DeadlockTest$1.secondMethod(DeadlockTest.java:70)
    at com.cloudbees.jenkins.support.timer.DeadlockTest$1.secondMethod(DeadlockTest.java:70)
    at com.cloudbees.jenkins.support.timer.DeadlockTest$1.secondMethod(DeadlockTest.java:70)
    at com.cloudbees.jenkins.support.timer.DeadlockTest$1.secondMethod(DeadlockTest.java:70)
    at com.cloudbees.jenkins.support.timer.DeadlockTest$1.secondMethod(DeadlockTest.java:70)
    at com.cloudbees.jenkins.support.timer.DeadlockTest$1.secondMethod(DeadlockTest.java:70)
    at com.cloudbees.jenkins.support.timer.DeadlockTest$1.secondMethod(DeadlockTest.java:70)
    at com.cloudbees.jenkins.support.timer.DeadlockTest$1.secondMethod(DeadlockTest.java:70)
    at com.cloudbees.jenkins.support.timer.DeadlockTest$1.secondMethod(DeadlockTest.java:70)
    at com.cloudbees.jenkins.support.timer.DeadlockTest$1.secondMethod(DeadlockTest.java:70)
    at com.cloudbees.jenkins.support.timer.DeadlockTest$1.secondMethod(DeadlockTest.java:70)
    at com.cloudbees.jenkins.support.timer.DeadlockTest$1.secondMethod(DeadlockTest.java:70)
    at com.cloudbees.jenkins.support.timer.DeadlockTest$1.secondMethod(DeadlockTest.java:70)
    at com.cloudbees.jenkins.support.timer.DeadlockTest$1.secondMethod(DeadlockTest.java:70)
    at com.cloudbees.jenkins.support.timer.DeadlockTest$1.secondMethod(DeadlockTest.java:70)
    at com.cloudbees.jenkins.support.timer.DeadlockTest$1.secondMethod(DeadlockTest.java:70)
    at com.cloudbees.jenkins.support.timer.DeadlockTest$1.secondMethod(DeadlockTest.java:70)
    at com.cloudbees.jenkins.support.timer.DeadlockTest$1.secondMethod(DeadlockTest.java:70)
    at com.cloudbees.jenkins.support.timer.DeadlockTest$1.firstMethod(DeadlockTest.java:66)
    at com.cloudbees.jenkins.support.timer.DeadlockTest$1.run(DeadlockTest.java:62)
    at java.lang.Thread.run(Thread.java:745)

@reviewbybees esp. @stephenc, @christ66

[ghost]

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

[stephenc]

🐝

[jenkinsadmin]

Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests.

[andresrc]

🐝

[christ66]

@jglick Thank you!