Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix duration_ms #6

Merged
merged 2 commits into from May 18, 2016

Conversation

Projects
None yet
7 participants
@forrest79
Copy link

forrest79 commented Mar 19, 2014

In this version is duration_ms in seconds but "ms" in variable name is little confusing :-) This fix requires duration_ms in milliseconds.

@cloudbees-pull-request-builder

This comment has been minimized.

Copy link

cloudbees-pull-request-builder commented Mar 19, 2014

plugins » tap-plugin #64 SUCCESS
This pull request looks good

@jenkinsadmin

This comment has been minimized.

Copy link
Member

jenkinsadmin commented Mar 19, 2014

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@kinow

This comment has been minimized.

Copy link
Member

kinow commented Oct 9, 2015

Hi @forrest79

Sorry for the delay. I'm on a roll fixing bugs, and will cut a few more releases.

I'll massage the code and will fix the conflicts to merge your pull request in the next days.

Thanks!

@harschware

This comment has been minimized.

Copy link

harschware commented May 17, 2016

Thanks for the TAP plugin! I also encountered this issue. I'm hoping a new release will come soon and include the fix.

@kinow kinow merged commit 1d964ea into jenkinsci:master May 18, 2016

@rvagg

This comment has been minimized.

Copy link

rvagg commented Jun 8, 2016

This is going to be a pretty awkward change to manage since reporters have standardised around duration_ms as being in seconds (e.g. the Node.js core test runner does this, as do some Node.js ecosystem tap reporters such as Hapi.js). The way I've learnt to read it to solve for the discrepancy is "duration including milliseconds". Perhaps instead of making a breaking change, an alternative could be introduced that is just duration and have that read in either seconds or milliseconds (it really doesn't matter what, since that'd be a new standard), and leave duration_ms for existing reporters that depend on reporting in a certain way.

@gibfahn

This comment has been minimized.

Copy link

gibfahn commented Jun 9, 2016

Perhaps the duration option could have an ms or s suffix, e.g. duration: 1.2s or duration: 1000.2ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.