Patch 1 #6

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
6 participants

div222 commented Mar 29, 2012

I've added some code which allows the testflight plugin to send a summary of SCM changes instead of a static text to TestFlight, as changes for a specific build. If no changes are found between 2 consecutive builds, the static default text is sent instead.

entity.addPart("api_token", new StringBody(apiToken));
entity.addPart("team_token", new StringBody(teamToken));
- entity.addPart("notes", new StringBody(vars.expand(buildNotes)));
+ //entity.addPart("notes", new StringBody(vars.expand(buildNotes)));
@stigkj

stigkj Mar 29, 2012

Member

Remember to remove code you have commented out

@@ -178,10 +188,29 @@ public boolean perform(AbstractBuild build, Launcher launcher, BuildListener lis
HttpPost httpPost = new HttpPost("/api/builds.json");
FileBody fileBody = new FileBody(file);
- MultipartEntity entity = new MultipartEntity();
+ String notes = "";
@stigkj

stigkj Mar 29, 2012

Member

Maybe initialize the variable with default build notes first, like this:

String notes = vars.expand(buildNotes);

Then the logic below can be simplified a bit.

@div222

div222 Mar 29, 2012

Yes, you're right

Member

stigkj commented Mar 29, 2012

This is a nice idea. Though it would be nice if you had the same formatting as the rest of the code, specifically indentation :-)

div222 commented Mar 29, 2012

Sorry about it. I can make the needed changes.

Member

stigkj commented Mar 29, 2012

No need to be sorry. It is great that you help out!

div222 commented Mar 29, 2012

I already use it and I imagine others might find it useful as well. So why keep it for myself?

Member

nheagy commented Apr 11, 2012

This definitely needs formatting to be fixed first.

Hey Div, great addition. Any chance you can fix up your patch?

Hey folks. I've submitted a pull request for something similar as an alternative. I didn't notice this until I went to submit the pull request.

#13

Member

lacostej commented Nov 26, 2012

I am merging pull request #2 instead. They provide similar functionality, the second one allows appending instead of replacing.

@lacostej lacostej closed this Nov 26, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment