From 47efb7273cebff2786c1446afb368a05dda3764f Mon Sep 17 00:00:00 2001 From: Oleg Nenashev Date: Fri, 2 Feb 2018 15:17:33 +0100 Subject: [PATCH] [JENKINS-49302] - integer escaping - YAGNI --- .../plugins/testlink/util/TestLinkHelper.java | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/src/main/java/hudson/plugins/testlink/util/TestLinkHelper.java b/src/main/java/hudson/plugins/testlink/util/TestLinkHelper.java index b3e5432..56170e5 100644 --- a/src/main/java/hudson/plugins/testlink/util/TestLinkHelper.java +++ b/src/main/java/hudson/plugins/testlink/util/TestLinkHelper.java @@ -338,7 +338,7 @@ public static EnvVars buildTestCaseEnvVars(int numberOfTests, TestProject testPr */ public static String createReportSummary(Report testLinkReport, Report previous) { StringBuilder builder = new StringBuilder(); - builder.append("

"+Messages.ReportSummary_Summary_BuildID(escape(testLinkReport.getBuildId()))+"

"); + builder.append("

"+Messages.ReportSummary_Summary_BuildID(testLinkReport.getBuildId())+"

"); builder.append("

"+Messages.ReportSummary_Summary_BuildName(Util.escape(testLinkReport.getBuildName()))+"

"); builder.append("

"); @@ -396,11 +396,11 @@ public static String createReportSummaryDetails(Report report, Report previous) { builder.append("\n"); - builder.append(""+escape(tc.getId())+""); + builder.append(""+tc.getId()+""); builder.append(""+Util.escape(tc.getFullExternalId())+""); - builder.append(""+escape(tc.getVersion())+""); + builder.append(""+tc.getVersion()+""); builder.append(""+Util.escape(tc.getName())+""); - builder.append(""+escape(tc.getTestProjectId())+""); + builder.append(""+tc.getTestProjectId()+""); builder.append(""+TestLinkHelper.getExecutionStatusTextColored( tc.getExecutionStatus() )+"\n"); builder.append("\n"); @@ -410,12 +410,6 @@ public static String createReportSummaryDetails(Report report, Report previous) return builder.toString(); } - private static String escape(Integer integer) { - return integer != null ? Util.escape(integer.toString()) : "null" ; - } - - - /** * Prints the difference between two int values, showing a plus sign if the * current number is greater than the previous.