Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the javax.xml.bind.DatatypeConverter as part of enabling Java 9 #220

Open
wants to merge 2 commits into
base: master
from

Conversation

@AniketSK
Copy link

AniketSK commented Feb 4, 2019

Since the javax.xml.bind package is removed in Java 9, it would help if
this package was removed from the code.
This was replaced with Apache Commons and not java.util.Base64 because
the encode function there requires compilation with java 8.

AniketSK added 2 commits Feb 4, 2019
Since the javax.xml.bind package is removed in Java 9, it would help if
this package was removed from the code.
This was replaced with Apache Commons and not java.util.Base64 because
the encode function there requires compilation with java 8.
Since the javax.xml.bind package is removed in Java 9, it would help if
this package was removed from the code.
This was replaced with Apache Commons and not java.util.Base64 because
the encode function there requires compilation with java 8.
@batmat

This comment has been minimized.

Copy link
Member

batmat commented Feb 5, 2019

@batmat
batmat approved these changes Feb 5, 2019
Copy link
Member

batmat left a comment

LGTM 👍

@batmat

This comment has been minimized.

Copy link
Member

batmat commented Feb 5, 2019

Copy link
Member

alecharp left a comment

Not a huge fan of the comment on the imports but LGTM

Copy link

MRamonLeon left a comment

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.