Replace the use of tf (command-line client) in *Command implementations.
#46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
August 7, 2015 15:11
Four tests no longer applied and were deleted, and two more were added.
A few tests no longer applied, most were adapted with minimal changes and a few new ones were added, although unfortunately the soapextensions.Workspace class is final (could not be mocked) and the two tests that create an instance had to become integration tests because they [briefly] connect to TFS.
This should help make it explicit that we're potentially downloading a whole lot of history.
We really just want to know what the latest changeset is, to compare against the baseline. This also is explicit that we need very few details and that we only download the 1, latest item.
It was probably obsoleted once a workspace was no longer required for polling.
There was only one subclass left, so it didn't make sense to keep the extra abstraction.
It was always false except for one test.
It was only ever used in tests.
Project.getFiles() discards the results of the GetFilesToWorkFolderCommand and thus the interface implementation wasn't [any longer] necessary, and since we removed the last implementation, the ParseableCommand<T> interface wasn't necessary.
This makes it so the TFVC checkout will always receive an explicit path, reducing ambiguity.
These used to be done separately due to the use of the CLC, but now it makes more sense to just call map() on the workspace we just created, instead of discarding said instance and later searching for it.
added 15 commits
August 8, 2015 14:13
It turns out that there is only one VersionControlClient instance provided by the TFSTeamProjectCollection instance, so it shouldn't be closed before we're completely done, which is when the Server instance gets closed. The MockableVersionControlClient was augmented with a makeSureNotClosed() method to catch future [premature] mis-uses of close().
|
Odd, the CloudBees automated build did not register the success of build 168. |
olivierdagenais
added a commit
that referenced
this pull request
Aug 13, 2015
Remove use of tf (command-line client) in *Command implementations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes the need to install the TEE CLC or Visual Studio Team Explorer on every agent, adding
tfto the PATH, etc.Testing
Integration tests were run on TFS 2012, 2013 and 2015, after removing the TEE CLC from the corresponding agents.