Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for relative paths for Folder Plugin #48

Merged
merged 15 commits into from Dec 4, 2014

Conversation

imakowski
Copy link
Contributor

Thanks to @sokar92 we have support for Folder Plugin. Please merge into your repository.

nmorey and others added 12 commits February 4, 2014 13:38
…va: Fix MatrixBuild support for SubBuild

Build was used in multiple place instead of AbstractBuild which means it failed when the sub build was a MatrixBuild.
Symptom was that the MatrixBuild was started but never joined and did not showed up as active in the MultiJob page.

Signed-off-by: Nicolas Morey-Chaisemartin <nmorey@kalray.eu>
When hudson is not at the top path of the webserver (ie htt://server/hudson/), the link to the sub job was broken.
Use ${rootURL} to fix this

Signed-off-by: Nicolas Morey-Chaisemartin <nmorey@kalray.eu>
…is view

Signed-off-by: Nicolas Morey-Chaisemartin <nmorey@kalray.eu>
Set jobBaseUrl in MultiJobView so that links to jobs will be under this view
Fix access URL for sub job in MultiJobBuild view
* src/main/java/com/tikal/jenkins/plugins/multijob/MultiJobBuilder.java:...
checked...
Folder support (Hierarchical jobs) for Multijob plugin
Relative paths for Folder Plugin support
@cloudbees-pull-request-builder

plugins » tikal-multijob-plugin #90 FAILURE
Looks like there's a problem with this pull request

@cloudbees-pull-request-builder

plugins » tikal-multijob-plugin #91 SUCCESS
This pull request looks good

@jenkinsadmin
Copy link
Member

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@imakowski
Copy link
Contributor Author

Is there any chance to release it fast 👍 This is enhancement for my previous pull request

@imakowski
Copy link
Contributor Author

@hagzag, @itaior, @alex-n could you please release this ASAP?

@cloudbees-pull-request-builder

plugins » tikal-multijob-plugin #92 FAILURE
Looks like there's a problem with this pull request

@cloudbees-pull-request-builder

plugins » tikal-multijob-plugin #93 SUCCESS
This pull request looks good

@alex-n
Copy link
Contributor

alex-n commented Feb 14, 2014

@imakowski It will take us a while to release next version. But you can easily build your hpi (from the current branch) and use it locally. Let me know if you need short explanation how to do it.

@imakowski
Copy link
Contributor Author

Could you please merge this into current version? This is over 18 days in waiting for marge stage. It would be very helpful for people who require relative paths in Multijob configuration.

@Brantone
Copy link

Status?!?

@imakowski
Copy link
Contributor Author

Tikal release cycle is sooooooo loooong...

On Thu, Oct 30, 2014, 10:06 PM Brenton B notifications@github.com wrote:

Status?!?


Reply to this email directly or view it on GitHub
#48 (comment)
.

@hagzag
Copy link
Member

hagzag commented Oct 31, 2014

I agree and we will do our best to work on releasing a new version next week @itaior & @alex-n are working on pushing this new version through.

@imakowski
Copy link
Contributor Author

Please merge this pull request into master

@hagzag
Copy link
Member

hagzag commented Nov 10, 2014

@itaior can we merge and release this addition / patch ?
10x
HP

@imakowski
Copy link
Contributor Author

Waiting with fingers crossed 👍

@ztec
Copy link

ztec commented Dec 3, 2014

When does this PR will be merged and released ?

@hagzag
Copy link
Member

hagzag commented Dec 3, 2014

@itaior is working on it, @itaior any ETA ?

Tx
HP

@imakowski
Copy link
Contributor Author

Hope this will be soon

@itaior itaior merged commit 6a83f73 into jenkinsci:master Dec 4, 2014
@hagzag
Copy link
Member

hagzag commented Dec 4, 2014

tested and prepped for 1.16 ...

Haggai Philip Zagury
DevOps Team

Tikal Knowledge LTD
T: +972 364 88618 | F: +972 364 88617 |M: +972-545-302525 |
hagzag@tikalk.com
http://www.tikalk.com

Join me online: [image: Facebook] http://www.hagzag.com [image: Facebook]
https://www.github.com/hagzag [image: Facebook]
https://www.facebook.com/hagzag [image: Twitter]
https://twitter.com/hagzag [image: Google Plus]
https://plus.google.com/114229050688726137151 [image: Linkedin]
http://il.linkedin.com/in/hagzag [image: Skype] http://www.skype.com

Please consider the impact on the environment before printing this e-mail.

On Thu, Dec 4, 2014 at 8:32 AM, itaior notifications@github.com wrote:

Merged #48 #48.


Reply to this email directly or view it on GitHub
#48 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants