Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-46753] Fixed PCT failure against core 2.73.1 #3

Merged
merged 3 commits into from Oct 14, 2017

Conversation

Projects
None yet
4 participants
@fcojfernandez
Copy link
Contributor

fcojfernandez commented Sep 8, 2017

JENKINS-46753

Fixed PCT failure against core 2.73.1. Missing dependency in scope test

@reviewbybees

@reviewbybees

This comment has been minimized.

Copy link

reviewbybees commented Sep 8, 2017

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@jglick jglick requested a review from andresrc Oct 4, 2017

pom.xml Outdated
@@ -6,7 +6,7 @@
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>plugin</artifactId>
<!-- Baseline Jenkins version you use to build and test the plugin. Users must have this version or newer to run. -->
<version>2.17</version>
<version>2.33</version>

This comment has been minimized.

Copy link
@recena

recena Oct 9, 2017

Contributor

@fcojfernandez Why not the latest one?

This comment has been minimized.

Copy link
@fcojfernandez

fcojfernandez Oct 9, 2017

Author Contributor

Version 2.33 was latest version at the time of the Pull Request. At present time, latest version is 2.36. I've upgraded and tested.

@recena @andresrc what do you think about this upgrade now?

@recena

recena approved these changes Oct 9, 2017

@recena

recena approved these changes Oct 14, 2017

@recena recena merged commit 3688261 into jenkinsci:master Oct 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.