Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED JENKINS-18283] Wrong URL in diff (and file view) #4

Merged
merged 2 commits into from Jan 23, 2014

Conversation

@ducquoc
Copy link
Contributor

commented Jun 14, 2013

When ViewVC is not install at root of server (http://www.mysvnserver.domain.com/) , for example:
http://www.mysvnserver.domain.com/viewvc
or
http://www.mysvnserver.domain.com/bin/viewvc.cgi

Then the diff link and view file link is not correct because it will append the SVN path to the bare URL (i.e. lost the "context" path):
http://www.mysvnserver.domain.com/SVN/path/here/as/checked/out/myfile.txt

The patch is my attempt to fix those URLs.

@buildhive

This comment has been minimized.

Copy link

commented Jun 14, 2013

Jenkins » viewVC-plugin #9 SUCCESS
This pull request looks good
(what's this?)

@jenkinsadmin

This comment has been minimized.

Copy link
Member

commented Sep 22, 2013

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@mrumpf mrumpf merged commit 659a0cf into jenkinsci:master Jan 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.