Make jenkins-slave.exe work on Server 2012 #3

Merged
merged 1 commit into from Jun 1, 2016

Conversation

Projects
None yet
5 participants
@daniel-beck
Member

daniel-beck commented Sep 24, 2015

Untested, got this from a comment to https://wiki.jenkins-ci.org/display/JENKINS/Windows+slaves+Plugin

@jenkinsadmin

This comment has been minimized.

Show comment
Hide comment
@jenkinsadmin

jenkinsadmin Sep 24, 2015

Member

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

Member

jenkinsadmin commented Sep 24, 2015

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@daniel-beck

This comment has been minimized.

Show comment
Hide comment
@daniel-beck

daniel-beck Dec 17, 2015

Member

@oleg-nenashev Maybe this is something you could verify? Do you still have your Windows (e.g. winsw) env?

Member

daniel-beck commented Dec 17, 2015

@oleg-nenashev Maybe this is something you could verify? Do you still have your Windows (e.g. winsw) env?

@oleg-nenashev

This comment has been minimized.

Show comment
Hide comment
@oleg-nenashev

oleg-nenashev Dec 17, 2015

Member

I have 1 Winserver 2012, so I can do it

Member

oleg-nenashev commented Dec 17, 2015

I have 1 Winserver 2012, so I can do it

@oleg-nenashev oleg-nenashev self-assigned this Dec 17, 2015

@oleg-nenashev

This comment has been minimized.

Show comment
Hide comment
@oleg-nenashev

oleg-nenashev Dec 17, 2015

Member

BTW I doubt such approach will work for winsw in general. Needs an investigation

Member

oleg-nenashev commented Dec 17, 2015

BTW I doubt such approach will work for winsw in general. Needs an investigation

@sakamotodesu

This comment has been minimized.

Show comment
Hide comment
@sakamotodesu

sakamotodesu May 24, 2016

I hope that this PR will be merged.
If more investigation is necessary, I can test on some Windows versions.

sakamotodesu commented May 24, 2016

I hope that this PR will be merged.
If more investigation is necessary, I can test on some Windows versions.

@kohsuke kohsuke merged commit 1f46622 into jenkinsci:master Jun 1, 2016

@kohsuke

This comment has been minimized.

Show comment
Hide comment
@kohsuke

kohsuke Jun 1, 2016

Member

I vouch for this change as well. See https://github.com/kohsuke/winsw#net-runtime-40

Member

kohsuke commented Jun 1, 2016

I vouch for this change as well. See https://github.com/kohsuke/winsw#net-runtime-40

kohsuke added a commit to jenkinsci/jenkins that referenced this pull request Jun 1, 2016

@kohsuke kohsuke referenced this pull request in jenkinsci/jenkins Jun 1, 2016

Merged

Pick up a new windows slave installer module #2386

olivergondza added a commit to jenkinsci/jenkins that referenced this pull request Jun 19, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment