Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upSmall RFE for dependency #12
Conversation
- Make jCIFS dependency local instead of relying on a dependency in core - Add Jenkinsfile for building
|
@slide I'd guess it's a follow-up to jenkinsci/jenkins#3318 . Could you please clarify what you're trying to achieve in this PR? Even if we have a library locally, there is no guarantee that classloading will actually happen from it |
|
@oleg-nenashev, yes, it's a follow up to that PR. I am trying to localize the dependency and I understand that without a change in core, the version from core will be loaded for now. This is just to allow removing the dependency from core at some future date. |
|
Even if you define a dependency here, you cannot guarantee that it will be actually loaded from here. Depends on the class loading order in this and other plugins. Once the core dependency changes, it may lead to upper bound dependency checks here. As we discussed in jenkinsci/jenkins#3318 , a correct way would be to detach the jcifs API Plugin from the core and then add a dependency on it in this plugin. |
|
The plan would be to remove the core dependency, there should be no reason to keep it. |
|
@escoem also pointed me to https://issues.jenkins-ci.org/browse/JENKINS-46255, which is kinda related. Maybe the plugin should just move out to another lib |
|
I am using jcifs-ng (https://github.com/AgNO3/jcifs-ng) now in po-cifs which has support for SMBv2 |
slide commentedMar 1, 2018