Skip to content

[JENKINS-24673] SimpleBuildWrapper #118

Closed

Description

@jenkins-infra-bot

This may be something that I've missed but how are you planing on adding support to add build wrappers to the Workflow plugin. We depend a lot on a few plugins to modify the console output to for example color code, find match patterns and to filter out password.


Originally reported by hanabishi, imported from: SimpleBuildWrapper
  • assignee: jglick
  • status: Resolved
  • priority: Major
  • component(s): pipeline
  • label(s): api
  • resolution: Fixed
  • resolved: 2015-06-02T01:40:26+00:00
  • votes: 3
  • watchers: 9
  • imported: 2025-12-08
Raw content of original issue

This may be something that I've missed but how are you planing on adding support to add build wrappers to the Workflow plugin. We depend a lot on a few plugins to modify the console output to for example color code, find match patterns and to filter out password.

Activity

  1. jenkins-infra-bot commented on Sep 11, 2014

    @jenkins-infra-bot
    Author
  2. jenkins-infra-bot commented on Dec 12, 2014

    @jenkins-infra-bot
    Author
    jglick:
    • Original comment link
    • Raw content of original comment:

      Build wrappers could perhaps be integrated by defining a SimpleBuildWrapper API (analogous to SimpleBuildStep and so taking Run and FilePath rather than AbstractBuild) where Environment is considered Serializable, and introducing a generic Step to run these. This could make it easier to use xvnc-plugin etc.

      The tool-env plugin does not need this, due to the standard tool step.

    Build wrappers could perhaps be integrated by defining a SimpleBuildWrapper API (analogous to SimpleBuildStep and so taking Run and FilePath rather than AbstractBuild) where Environment is considered Serializable, and introducing a generic Step to run these. This could make it easier to use xvnc-plugin etc.

    The tool-env plugin does not need this, due to the standard tool step.

  3. jenkins-infra-bot commented on Jan 14, 2015

    @jenkins-infra-bot
    Author
    jglick:
    • Original comment link
    • Raw content of original comment:

      Went ahead and wrote a custom Step for the Credentials Binding plugin, though it could perhaps have been written using the API under development.

      Not currently attempting to handling wrappers which decorate the console, as I do not see any straightforward way to support this transparently. If you have some specific plugins in mind, please list the most important ones so I can study what they do and whether that can possibly make sense from within a workflow.

    Went ahead and wrote a custom Step for the Credentials Binding plugin, though it could perhaps have been written using the API under development.

    Not currently attempting to handling wrappers which decorate the console, as I do not see any straightforward way to support this transparently. If you have some specific plugins in mind, please list the most important ones so I can study what they do and whether that can possibly make sense from within a workflow.

  4. jenkins-infra-bot commented on Jan 16, 2015

    @jenkins-infra-bot
    Author
    scm_issue_link:

    Code changed in jenkins
    User: Jesse Glick
    Path:
    COMPATIBILITY.md
    http://jenkins-ci.org/commit/workflow-plugin/f3f8cc06f50be32ae54783c959ea916f803dfa83
    Log:
    Updates related to JENKINS-24673">JENKINS-24673

  5. jenkins-infra-bot commented on Jan 23, 2015

    @jenkins-infra-bot
    Author
    scm_issue_link:

    Code changed in jenkins
    User: Jesse Glick
    Path:
    changelog.html
    core/src/main/java/jenkins/tasks/SimpleBuildWrapper.java
    test/src/test/java/jenkins/tasks/SimpleBuildWrapperTest.java
    http://jenkins-ci.org/commit/jenkins/416bdef94db123ed8d051d095007491c9184b6ce
    Log:
    JENKINS-24673">JENKINS-24673 Noting merge of #1530.

    Compare: jenkinsci/jenkins@1dd60ec...416bdef

  6. jenkins-infra-bot commented on Jan 23, 2015

    @jenkins-infra-bot
    Author
    jglick:
    • Original comment link
    • Raw content of original comment:

      Core change merged towards 1.599.

    Core change merged towards 1.599.

  7. jenkins-infra-bot commented on Mar 13, 2015

    @jenkins-infra-bot
    Author
    hanabishi:

    Was looking a bit more on this now that I got some free time again, the only thing we need right now is to be able to create a wrapper for the listener output. So we can filter the output and color code the output. For example we have a plugin that formats or output simular to https://wiki.jenkins-ci.org/display/JENKINS/Timestamper and https://wiki.jenkins-ci.org/display/JENKINS/AnsiColor+Plugin as well as a plugin to filer out passwords from the console.

  8. jenkins-infra-bot commented on Mar 16, 2015

    @jenkins-infra-bot
    Author
    jglick:

    hanabishi see JENKINS-27392">JENKINS-27392.

  9. jenkins-infra-bot commented on Jun 2, 2015

    @jenkins-infra-bot
    Author
    jglick:
    • Original comment link
    • Raw content of original comment:

      Workflow 1.8 has the new wrap step.

    Workflow 1.8 has the new wrap step.

  10. jenkins-infra-bot commented on Dec 8, 2025

    @jenkins-infra-bot
    Author

    [Original depends_on from Jira: JENKINS-26552]

  11. jenkins-infra-bot commented on Dec 8, 2025

    @jenkins-infra-bot
    Author

    [Original depends_on from Jira: JENKINS-28719]

  12. jenkins-infra-bot commented on Dec 8, 2025

    @jenkins-infra-bot
    Author

    [Original depends_on from Jira: JENKINS-27392]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions