Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-29922] marking a meta step as such #10

Merged
merged 10 commits into from Jul 28, 2016

Conversation

Projects
None yet
5 participants
@kohsuke
Copy link
Member

kohsuke commented Jun 29, 2016

let's hold the merge until all the changes for JENKINS-29922 is ready

kohsuke and others added some commits Jun 29, 2016

@jglick jglick closed this Jul 11, 2016

@jglick jglick reopened this Jul 11, 2016

jglick added some commits Jul 11, 2016

@kohsuke

This comment has been minimized.

Copy link
Member Author

kohsuke commented Jul 11, 2016

This PR and other JENKINS-29922 PRs are ready to merge: @reviewbybees

@reviewbybees

This comment has been minimized.

Copy link

reviewbybees commented Jul 11, 2016

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@abayer

This comment has been minimized.

Copy link
Member

abayer commented Jul 11, 2016

🐝

pom.xml Outdated
@@ -121,7 +121,7 @@
<dependency>
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>junit</artifactId>
<version>1.9</version>
<version>1.15-SNAPSHOT</version>

This comment has been minimized.

Copy link
@jglick

jglick Jul 12, 2016

Member

🐛 use 1.15

@kohsuke kohsuke closed this Jul 12, 2016

@kohsuke kohsuke reopened this Jul 12, 2016

@kohsuke kohsuke closed this Jul 12, 2016

@kohsuke kohsuke reopened this Jul 12, 2016

@kohsuke

This comment has been minimized.

Copy link
Member Author

kohsuke commented Jul 12, 2016

Redeployed every jar in related plugins.

@svanoort

This comment has been minimized.

Copy link
Member

svanoort commented Jul 27, 2016

🐝


@Test public void artifactArchiver() throws Exception {
WorkflowJob p = r.jenkins.createProject(WorkflowJob.class, "p");
// TODO 2.7.x+ use core symbols
p.setDefinition(new CpsFlowDefinition("node {writeFile text: '', file: 'x.txt'; step([$class: 'ArtifactArchiver', artifacts: 'x.txt', fingerprint: true])}", true));

This comment has been minimized.

Copy link
@abayer

abayer Jul 27, 2016

Member

Ah, that answers my question from jenkinsci/workflow-cps-plugin#28. =)

@abayer

This comment has been minimized.

Copy link
Member

abayer commented Jul 27, 2016

🐝

@abayer abayer referenced this pull request Jul 27, 2016

Merged

[JENKINS-29922] $class must die #28

7 of 7 tasks complete
@kohsuke

This comment has been minimized.

Copy link
Member Author

kohsuke commented Jul 27, 2016

🐝

@jglick jglick merged commit dd94fa9 into master Jul 28, 2016

1 check passed

Jenkins This pull request looks good
Details

@jglick jglick deleted the JENKINS-29922 branch Jul 28, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.