Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-31931] Adding test case #17

Merged
merged 1 commit into from Sep 21, 2016
Merged

Conversation

@jglick
Copy link
Member

jglick commented Aug 29, 2016

JENKINS-31931

Also fixing a buglet that archiving from a nonexistent workspace should not automatically fail, except insofar as archiving no files would. Cf. JENKINS-28121 which also deals with nonexistent workspaces. Generally it is up to each step which expects a context directory to exist to actually make that directory; otherwise dir('mayOrMayNotExist') {fileExists 'something'} would gratuitously mkdirs, for example.

@reviewbybees

Also fixing a buglet with nonexistent workspaces.
@reviewbybees

This comment has been minimized.

Copy link

reviewbybees commented Aug 29, 2016

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@svanoort

This comment has been minimized.

Copy link
Member

svanoort commented Sep 19, 2016

🐝

@jglick jglick merged commit 05bf1fb into jenkinsci:master Sep 21, 2016
1 check passed
1 check passed
Jenkins This pull request looks good
Details
@jglick jglick deleted the jglick:test-JENKINS-31931 branch Sep 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.