Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a requireSteps step #33

Closed
wants to merge 1 commit into from
Closed

Conversation

@batmat
Copy link
Member

batmat commented Jan 15, 2017

Some followup of #31 which made me think it would be nice to be more specific. Also, it's sometimes a headache for users to be sure where steps should be coming from.

Sample usage:

requireSteps steps:['pwd','findFiles']

NOTE: this checks only on functions and symbols, not on global variables. @jglick I am not sure how to do that, apart from adding a dependency against groovy-cps which I suspect is probably not the way to go right?

@batmat batmat force-pushed the batmat:requireSteps branch from c30d5ba to ddbc49d Jan 15, 2017
@jglick
Copy link
Member

jglick commented Feb 10, 2017

it's sometimes a headache for users to be sure where steps should be coming from

Which is why we need Pipeline Syntax support, which is what I was talking about in #31. And that is not possible until @svanoort finishes jenkinsci/workflow-api-plugin#26.

@svanoort
Copy link
Member

svanoort commented Feb 10, 2017

@jglick I'm rather unclear why the StepAction is a precursor for pipeline syntax support?

I am only implementing JENKINS-37324, not JENKINS-31582 here -- perhaps there's a mapping from the Descriptor that I'm not aware of?

@HRMPW
Copy link

HRMPW commented Feb 28, 2017

As I said in PR-31, I think the best user experience for this would be to build this into Declarative to be automatic. steps are explicit in Declarative except for anything in a script block. Making a user type in a list of steps they want to use when we already know the list of steps that are being used seems like an unnecessary ask of the Pipeline builder.

If we build this for Scripted and require the user to list the steps included in the Pipeline then that is fine but for Declarative we should automatically fill the list of steps used for the user.

@batmat
Copy link
Member Author

batmat commented Mar 30, 2017

Closing in favor of #31 as per apparent trend above. Cleaning up my open PR list a bit.

@batmat batmat closed this Mar 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.