Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-26107] Examples for blocky stage #11

Merged
merged 4 commits into from Aug 31, 2016

Conversation

Projects
None yet
4 participants
@jglick
Copy link
Member

commented May 12, 2016

@@ -46,31 +46,25 @@ samples.push({
name: 'hello',
title: 'Hello World',
script: "node {\n" +
" stage 'Stage 1'\n" +

This comment has been minimized.

Copy link
@jglick

jglick May 12, 2016

Author Member

Just seemed gratuitous here.

snippet node-l\n\
node ('${1}') {\n\
\n\
}\n\

This comment has been minimized.

Copy link
@jglick

jglick May 12, 2016

Author Member

redundant

# node\n\
snippet node\n\
node {\n\
${1}\n\
}\n\
# node-l ('label') \n\
snippet node-l\n\
node ('${1}') {\n\
node('${1}') {\n\

This comment has been minimized.

Copy link
@jglick

jglick May 12, 2016

Author Member

Bringing snippet style in line with what Snippetizer and most docs would suggest.

@reviewbybees

This comment has been minimized.

Copy link

commented May 12, 2016

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@kohsuke

This comment has been minimized.

Copy link
Member

commented May 23, 2016

🐝

@@ -45,38 +45,37 @@ function getSample(sampleName) {
samples.push({
name: 'hello',
title: 'Hello World',
script: "node {\n" +
" stage 'Stage 1'\n" +

This comment has been minimized.

Copy link
@jglick

jglick Aug 29, 2016

Author Member

Just seemed gratuitous here.

" bat(/\"${mvnHome}\\bin\\mvn\" -Dmaven.test.failure.ignore clean package/)\n" +
" }\n" +
" }\n" +
" stage('Results') {\n" +

This comment has been minimized.

Copy link
@jglick

jglick Aug 29, 2016

Author Member

Adding a new stage here.

@svanoort

This comment has been minimized.

Copy link
Member

commented Aug 30, 2016

@jglick Block scoped stage is now live and hitting the update center, can we go ahead and merge?

@jglick

This comment has been minimized.

Copy link
Member Author

commented Aug 30, 2016

Yup, let me just do one last sanity check…

@@ -153,12 +153,6 @@
</dependency>
<dependency>
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>pipeline-stage-step</artifactId>

This comment has been minimized.

Copy link
@svanoort

svanoort Aug 30, 2016

Member

🐛 you'll still need a dependency on pipeline-stage-step 2.2 for the example to actually run.

This comment has been minimized.

Copy link
@jglick

jglick Aug 30, 2016

Author Member

Actually running the example requires all sorts of plugins which workflow-cps does not depend on. If we could define this snippets in another plugin like workflow-aggregator, I would do that, but @tfennelly did not write such an extension point.

This comment has been minimized.

Copy link
@jglick

jglick Aug 30, 2016

Author Member

Anyway this was a test-scoped dependency to begin with, which was only needed by the previous version of SnippetizerTest.

This comment has been minimized.

Copy link
@svanoort

svanoort Aug 30, 2016

Member

Ah, okay that makes it clearer. Okay, retracting my bug and granting the 🐝 instead!

@jglick jglick merged commit 4969ce0 into jenkinsci:master Aug 31, 2016

1 check passed

Jenkins This pull request looks good
Details

@jglick jglick deleted the jglick:stage-examples-JENKINS-26107 branch Aug 31, 2016

svanoort pushed a commit that referenced this pull request Apr 6, 2017

Merge pull request #11 from jglick/shared-libs-JENKINS-31155
Introduced FlowCopier extension point
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.