Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED JENKINS-44619] Don't allow replays of nonbuildable jobs #173

Merged
merged 3 commits into from Oct 19, 2017

Conversation

@abayer
Copy link
Member

commented Sep 18, 2017

@abayer abayer requested review from jglick and svanoort Sep 18, 2017

@reviewbybees

This comment has been minimized.

Copy link

commented Sep 18, 2017

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@jglick
jglick approved these changes Sep 18, 2017
Copy link
Member

left a comment

Also recommended in JIRA that

doRun should also report an HTTP error if run returns null

@abayer

This comment has been minimized.

Copy link
Member Author

commented Sep 18, 2017

@jglick What error would you recommend?

@jglick

This comment has been minimized.

Copy link
Member

commented Sep 27, 2017

What error would you recommend?

Could use a 409, as here.

@svanoort
Copy link
Member

left a comment

Yeah, I'd actually really like to see that HTTP error if replay is not allowed too.

@abayer

This comment has been minimized.

Copy link
Member Author

commented Oct 17, 2017

@svanoort Updated to throw an http error.

@svanoort

This comment has been minimized.

Copy link
Member

commented Oct 17, 2017

@abayer Looking good here!

@abayer abayer merged commit 59c88c7 into jenkinsci:master Oct 19, 2017

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.