Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED JENKINS-42471] Switch to Declarative in samples #207

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@abayer
Copy link
Member

abayer commented Feb 26, 2018

JENKINS-42471

I kept the GitHub + Maven Scripted example as well but renamed it Scripted Pipeline.

cc @reviewbybees

@abayer abayer requested review from jglick, rsandell and svanoort Feb 26, 2018

" sh \"mvn -Dmaven.test.failure.ignore=true clean package\"\n" +
"\n" +
" // To run Maven on a Windows agent, use\n" +
" // bat \"mvn -Dmaven.test.failure.ignore=true clean package\"\n" +

This comment has been minimized.

Copy link
@jglick

jglick Feb 27, 2018

Member

Well this is pretty unfortunate.

This comment has been minimized.

Copy link
@rsandell
" }\n" +
" stage('Results') {\n" +
" junit '**/target/surefire-reports/TEST-*.xml'\n" + // assumes junit & workflow-basic-steps up to date
" archiveArtifacts 'target/*.jar'\n" + // TODO Jenkins 2 use archiveArtifacts instead

This comment has been minimized.

Copy link
@jglick

jglick Feb 27, 2018

Member

delete the obsolete comment

@svanoort
Copy link
Member

svanoort left a comment

Still needs a Scripted "hello world" present, and would be nice to somehow handle the Windows vs. Unix issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.