Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplifying snippetizer link URL construction #217

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@abayer
Copy link
Member

abayer commented Apr 2, 2018

Minor cleanup after comments on #209

@abayer abayer requested review from jglick and svanoort Apr 2, 2018

@jglick

jglick approved these changes Apr 5, 2018

}

return toAppend.toString();
return req.getContextPath() + '/' + (i == null ? "" : i.getUrl()) + u;

This comment has been minimized.

Copy link
@jglick

jglick Apr 5, 2018

Member

I assume you manually tested both cases here?

}

return toAppend.toString();
return req.getContextPath() + '/' + (i == null ? "" : i.getUrl()) + u;

This comment has been minimized.

Copy link
@svanoort

svanoort Apr 5, 2018

Member

Wait, why did we remove the check for if the context path has a '/' on it? We had an actual stage view bug that resulted from a similar issue.

Edit: even if it "shouldn't" happen it's a harmless check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.