Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-40109] Make compilation errors serializable #250

Merged
merged 1 commit into from Oct 2, 2018

Conversation

Projects
None yet
3 participants
@dwnusbaum
Copy link
Member

commented Oct 1, 2018

See JENKINS-40109.

This PR makes compilation errors thrown by LoadStep serializable, and exposes an exception that is reused to fix similar errors when loading shared libraries in jenkinsci/workflow-cps-global-lib-plugin#54

@reviewbybees

@abayer

abayer approved these changes Oct 1, 2018

Copy link
Member

left a comment

woot!

@abayer

This comment has been minimized.

Copy link
Member

commented Oct 1, 2018

fwiw, it wouldn't shock me if there are other places where plugins may want to use this - I feel like there are other non-coreish plugins that do loading/compilation within a Pipeline. Ok, yeah, there's definitely pipeline-remote-loader but I think that one's deprecated anyway. Still, another good reason to put the exception here. =)

@dwnusbaum

This comment has been minimized.

Copy link
Member Author

commented Oct 1, 2018

Downstream PR is up at jenkinsci/workflow-cps-global-lib-plugin#54, so I'm removing the work-in-progress label.

@svanoort
Copy link
Member

left a comment

Good catch, @dwnusbaum -- LGTM, please merge and release ASAP

@dwnusbaum dwnusbaum merged commit c0304b6 into jenkinsci:master Oct 2, 2018

2 checks passed

continuous-integration/jenkins/incrementals Deployed to Incrementals.
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details

@dwnusbaum dwnusbaum deleted the dwnusbaum:JENKINS-40109 branch Oct 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.