[FIXED JENKINS-37538] Set the context class loader to a neutral value inside step executions #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gin code while running steps.
|
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
jglick
changed the title
|
🐝 |
|
LGTM 🐝 |
svanoort
added a commit
that referenced
this pull request
Sep 28, 2017
…okup [JENKINS-37573] / [JENKINS-45553] Provide a fast view of block structures in the flow graph
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JENKINS-37538
Amends #42. Probably fixes a bug which I have not yet been able to reproduce. My working hypothesis is that with certain class loaders as
Thread.contextClassLoader,SAXParserFactory.newInstance()fails for reasons TBD but probably related to a mismatch between theClassLoaderdefining some copy ofSAXParserFactoryand one defining a copy oforg.apache.xerces.jaxp.SAXParserFactoryImpl, due to a design flaw inServiceLoader.My first thought was to use
d.clazz.getClassLoader()so that theStep’s own plugin code would be available, but in the case ofartifactory(cf. jfrog/jenkins-artifactory-plugin#30) this will delegate to the loader ofparameterized-triggerwhich currently (reasons TBD) bundlesWEB-INF/lib/xercesImpl-2.9.1.jar, so that is still possibly a problem. Instead I am taking the more conservative choice of the context loader in effect for most other plugin code in Jenkins, leaving the use ofGroovyClassLoader.InnerLoaderto code run directly from Pipeline script.@reviewbybees