Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JEP-210] Integration tests with DurableTaskStep #21

Merged
merged 47 commits into from Oct 4, 2018

Conversation

@jglick
Copy link
Member

commented Oct 4, 2016

Integration tests for jenkinsci/workflow-job-plugin#27.

JEP-210

  • basic implementation passing existing tests
  • specific test of a remote log stream
  • automated Unicode handling test
  • interactive Unicode handling test on Windows
  • check BindingStepTest with a remote logger
  • check WithContainerStepTest on an agent
  • prototype against Logstash: jenkinsci/logstash-plugin#18
@reviewbybees

This comment has been minimized.

Copy link

commented Oct 4, 2016

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

jglick added 4 commits Feb 5, 2018
}

@Override public void output(InputStream stream) throws Exception {
IOUtils.copy(stream, listener.getLogger());

This comment has been minimized.

Copy link
@jglick

jglick Feb 6, 2018

Author Member

This needs to be interrupted somehow when stop is called.

This comment has been minimized.

Copy link
@jglick

jglick Jun 11, 2018

Author Member

(from #63)

jglick added 2 commits Aug 8, 2018
jglick added 4 commits Aug 13, 2018
More interesting ShellStepTest.remoteLogger: upcase output on the rem…
…ote side, demonstrating that the BindingStep.Filter is operating there.

@jglick jglick requested review from abayer, dwnusbaum and rsandell Aug 15, 2018

private static class RemotableBuildListener implements BuildListener {
private static final long serialVersionUID = 1;
/** actual implementation */
private final TaskListener delegate;

This comment has been minimized.

Copy link
@jglick

jglick Aug 25, 2018

Author Member

Would be nice to have another test here too, which would produce a large volume of output, using a listener that did not delegate but wrote independently to a separate file, and use Channel.Listener.onRead/.onWrite to demonstrate that there is little traffic…unless you disable watch mode, as a control.

This comment has been minimized.

Copy link
@jglick

jglick Sep 4, 2018

Author Member

(resolved)

jglick added 5 commits Sep 4, 2018
@svanoort
Copy link
Member

left a comment

Yeah, okay

@jglick jglick changed the title [JEP-210] Remote log-friendly DurableTaskStep [JEP-210] Integration tests with DurableTaskStep Sep 13, 2018

jglick added 3 commits Sep 25, 2018

@jglick jglick merged commit 3bf52a2 into jenkinsci:master Oct 4, 2018

2 checks passed

continuous-integration/jenkins/incrementals Deployed to Incrementals.
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details

@jglick jglick deleted the jglick:logs-JENKINS-38381 branch Oct 4, 2018

orgi pushed a commit to orgi/workflow-durable-task-step-plugin that referenced this pull request Nov 13, 2018
Merge pull request jenkinsci#21 from jglick/logs-JENKINS-38381
[JEP-210] Integration tests with DurableTaskStep
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.