Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-34021] Do not overreact if a shell step is abruptly stopped #33

Merged
merged 1 commit into from Mar 9, 2017

Conversation

Projects
None yet
3 participants
@jglick
Copy link
Member

jglick commented Mar 7, 2017

JENKINS-34021

Amends #28 to not print misleading exceptions if a shell step has been forcibly stopped.

@reviewbybees

@jglick

This comment has been minimized.

Copy link
Member Author

jglick commented Mar 7, 2017

Note that CpsStepContext.isReady does not tell us whether getThread(CpsThreadGroup) is going to return non-null; you just need to try calling get(Class) and handle errors.

@reviewbybees

This comment has been minimized.

Copy link

reviewbybees commented Mar 7, 2017

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@abayer

abayer approved these changes Mar 8, 2017

@jglick jglick merged commit 1396e6f into jenkinsci:master Mar 9, 2017

1 check passed

Jenkins This pull request looks good
Details

@jglick jglick deleted the jglick:dead-shell-step-JENKINS-34021 branch Mar 9, 2017

jglick added a commit to jglick/workflow-durable-task-step-plugin that referenced this pull request Feb 5, 2018

orgi pushed a commit to orgi/workflow-durable-task-step-plugin that referenced this pull request Nov 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.